-
-
Notifications
You must be signed in to change notification settings - Fork 31.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix LaMetric Config Flow for SKY #93483
Conversation
Hey there @robbiet480, @frenck, @bachya, mind taking a look at this pull request as it has been labeled with an integration ( Code owner commandsCode owners of
|
Please take a look at the requested changes, and use the Ready for review button when you are done, thanks 👍 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please make sure to add tests for this (which is required for config_flows).
../Frenck
be5d9fb
to
e7680f5
Compare
Added two test cases, one for the TIME and one for the SKY ("sa5") |
@frenck Added a separate fixture for the SKY 👍 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, @spyfly 👍
../Frenck
Co-authored-by: Franck Nijhof <[email protected]>
Proposed change
Fixes the configuration flow for LaMetric SKY
Adds a check for the model type and disables the notification sound for the SKY ("sa5") in the configuration flow.
Type of change
Additional information
Checklist
black --fast homeassistant tests
)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest
.requirements_all.txt
.Updated by running
python3 -m script.gen_requirements_all
..coveragerc
.To help with the load of incoming pull requests: