Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Google Assistant SDK: Always enable conversation agent and support multiple languages #93201

Merged
merged 4 commits into from
Jun 30, 2023
Merged

Google Assistant SDK: Always enable conversation agent and support multiple languages #93201

merged 4 commits into from
Jun 30, 2023

Conversation

tronikos
Copy link
Member

@tronikos tronikos commented May 17, 2023 •
edited
Loading

Proposed change

Now that multiple conversation agents are supported there is no reason to have an option to enable/disable the conversation agent provided by Google Assistant SDK integration. Always enable the agent to simplify code and help users discover it.

Also properly implement the recently added supported_languages.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • I have followed the perfect PR recommendations
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
  • Untested files have been added to .coveragerc.

To help with the load of incoming pull requests:

@tronikos tronikos mentioned this pull request May 17, 2023
Merged
8 tasks
@tronikos tronikos marked this pull request as ready for review May 17, 2023 08:31
@balloob balloob added this to the 2023.7.0 milestone Jun 30, 2023
@balloob balloob merged commit 17ceacd into home-assistant:dev Jun 30, 2023
balloob pushed a commit that referenced this pull request Jun 30, 2023
@tronikos @balloob
Google Assistant SDK: Always enable conversation agent and support mu…
97d9876 
…ltiple languages (#93201)

* Enable agent and support multiple languages

* fix test
@github-actions github-actions bot locked and limited conversation to collaborators Jul 1, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@balloob balloob balloob approved these changes

Assignees
No one assigned
Labels
by-code-owner cherry-picked cla-signed has-tests integration: google_assistant_sdk new-feature Quality Scale: platinum small-pr PRs with less than 30 lines.
Projects
None yet
Milestone
2023.7.0
Development

Successfully merging this pull request may close these issues.
2 participants
@tronikos @balloob