Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bump beacontools to fix conflict with construct<2.10 and >=2.8.16 #92293

Merged
merged 1 commit into from
Apr 30, 2023
Merged

Bump beacontools to fix conflict with construct<2.10 and >=2.8.16 #92293

merged 1 commit into from
Apr 30, 2023

Conversation

bdraco
Copy link
Member

@bdraco bdraco commented Apr 30, 2023 •
edited
Loading

Proposed change

I don't have a way to test if the new version works though since pybluez is also broken. I'm not sure if the integration actually works for anyone at this point given #89484. Considering the current version is trying to use an even older version of pybluez, bumping beacontools seemed like the safest path forward

broken run https://github.com/home-assistant/core/actions/runs/4842366646/jobs/8629271498

test run https://github.com/home-assistant/core/actions/runs/4844696448

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • I have followed the perfect PR recommendations
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
  • Untested files have been added to .coveragerc.

To help with the load of incoming pull requests:

@bdraco bdraco added this to the 2023.5.0 milestone Apr 30, 2023
@bdraco bdraco mentioned this pull request Apr 30, 2023
Merged
20 tasks
@bdraco bdraco marked this pull request as ready for review April 30, 2023 14:11
frenck
frenck approved these changes Apr 30, 2023
View reviewed changes
Copy link
Member

@frenck frenck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @bdraco 👍

../Frenck

@frenck frenck merged commit a08cda3 into dev Apr 30, 2023
@frenck frenck deleted the beacontools branch April 30, 2023 16:06
frenck pushed a commit that referenced this pull request Apr 30, 2023
@bdraco @frenck
Bump beacontools to fix conflict with construct<2.10 and >=2.8.16 (#9…
c4aa6ba 
…2293)
raman325 added a commit to raman325/home-assistant that referenced this pull request Apr 30, 2023
@raman325
Merge branch 'dev' into datetime_2
19246c7 
* dev: (581 commits)
  Only store and pass around coordinator in Rituals Perfume Genie (home-assistant#92298)
  Avoid returning statistics columns that the metadata knows are impossible (home-assistant#92095)
  Add `date` platform (home-assistant#81948)
  Prevent pysnmp from being installed as it does not work with newer python (home-assistant#92292)
  Use SnapshotAssertion in Renault tests (home-assistant#90778)
  Home Connect add WasherDryer support (home-assistant#90673)
  Move lastfm constants to separate file (home-assistant#92289)
  Fix august lock state when API reports locking and locked with the same timestamp (home-assistant#92276)
  Ensure onvif webhook can be registered (home-assistant#92295)
  Bump beacontools to fix conflict with construct<2.10 and >=2.8.16 (home-assistant#92293)
  Bump pynina to 0.3.0 (home-assistant#92286)
  Fix mqtt not available when starting snips (home-assistant#92296)
  Extract Rituals Perfume Genie DataUpdateCoordinator into module (home-assistant#92284)
  Bump bleak to 0.20.2 (home-assistant#92294)
  Add missing fstrings in Local Calendar (home-assistant#92288)
  Remove myself from switcher_kis codeowners (home-assistant#92277)
  Handle AttributeError from wrong port in ONVIF config flow (home-assistant#92272)
  Auto repair incorrect collation on MySQL schema (home-assistant#92270)
  Update orjson to 3.8.11 (home-assistant#92228)
  Update coverage to 7.2.4 (home-assistant#92229)
  ...
@github-actions github-actions bot locked and limited conversation to collaborators May 1, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@frenck frenck frenck approved these changes

Assignees
No one assigned
Labels
cherry-picked cla-signed dependency integration: eddystone_temperature Quality Scale: No score small-pr PRs with less than 30 lines.
Projects
None yet
Milestone
2023.5.0
Development

Successfully merging this pull request may close these issues.
2 participants
@bdraco @frenck