Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix MQTT certificate files setup #92266

Merged
merged 1 commit into from
Apr 29, 2023

Conversation

jbouwh
Copy link
Contributor

@jbouwh jbouwh commented Apr 29, 2023

Proposed change

The MQTT certificate files should be prepared before the MQTT client is initiated to load them.

The regression was caused by #90529. From this PR on the certificate files no longer created before the MQTT client was initiated.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • I have followed the perfect PR recommendations
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
  • Untested files have been added to .coveragerc.

To help with the load of incoming pull requests:

@home-assistant
Copy link

Hey there @emontnemery, mind taking a look at this pull request as it has been labeled with an integration (mqtt) you are listed as a code owner for? Thanks!

Code owner commands

Code owners of mqtt can trigger bot actions by commenting:

  • @home-assistant close Closes the pull request.
  • @home-assistant rename Awesome new title Renames the pull request.
  • @home-assistant reopen Reopen the pull request.
  • @home-assistant unassign mqtt Removes the current integration label and assignees on the pull request, add the integration domain after the command.

@jbouwh jbouwh marked this pull request as ready for review April 29, 2023 20:47
@jbouwh jbouwh requested a review from emontnemery as a code owner April 29, 2023 20:47
@jbouwh jbouwh added the bugfix label Apr 29, 2023
@jbouwh jbouwh added this to the 2023.5.0 milestone Apr 29, 2023
@jbouwh jbouwh force-pushed the mqtt-fix-setup-certfiles branch from 2c3aa03 to b54ffa2 Compare April 29, 2023 20:53
@jbouwh jbouwh merged commit 9468aed into home-assistant:dev Apr 29, 2023
@jbouwh jbouwh deleted the mqtt-fix-setup-certfiles branch April 29, 2023 22:01
balloob pushed a commit that referenced this pull request Apr 30, 2023
@github-actions github-actions bot locked and limited conversation to collaborators May 1, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

MQTT fails to start with client certificate
4 participants