-
-
Notifications
You must be signed in to change notification settings - Fork 31.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Turn AVM FRITZ!Box Tools call deflection switches into coordinator entities #91913
Turn AVM FRITZ!Box Tools call deflection switches into coordinator entities #91913
Conversation
Hey there @mammuth, @AaronDavidSchneider, @chemelli74, mind taking a look at this pull request as it has been labeled with an integration ( Code owner commandsCode owners of
|
d74644b
to
123cf30
Compare
Please take a look at the requested changes, and use the Ready for review button when you are done, thanks 👍 |
Co-authored-by: Franck Nijhof <[email protected]>
Co-authored-by: Franck Nijhof <[email protected]>
Co-authored-by: Franck Nijhof <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, @mib1185 👍
../Frenck
Thanks for your review @frenck , now take a break and enjoy your holiday 🍻 |
…tities (#91913) Co-authored-by: Franck Nijhof <[email protected]>
Proposed change
This reduces the API calls, prior each existing call deflection caused one API call to fetch all deflections and filter to the current one, now all call deflections are get by the coordinator once and each call deflection entity use the data from coordinator. If there are about 20 existing call deflections, only 1 call is made as opposed to 20 before.
This is also the pre-work for migrating the other switch (port forwarding, wifi and profile) entities.
Type of change
Additional information
Checklist
black --fast homeassistant tests
)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest
.requirements_all.txt
.Updated by running
python3 -m script.gen_requirements_all
..coveragerc
.To help with the load of incoming pull requests: