-
-
Notifications
You must be signed in to change notification settings - Fork 31.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix false positive in SQL sensor full table scan check #91134
Conversation
Hey there @dgomes, @gjohansson-ST, mind taking a look at this pull request as it has been labeled with an integration ( Code owner commandsCode owners of
|
Looks like this won't catch if you're selecting more than just the entity_id column? |
good call we should do |
adjusted in 34230c7 |
Thanks to all who helped to address this. |
Thanks! |
Proposed change
Fix false positive in SQL sensor full table scan check. It was reported that this check unexpected matched a custom view called
view_sensor_db_unique_entity_ids
.Type of change
Additional information
Checklist
black --fast homeassistant tests
)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest
.requirements_all.txt
.Updated by running
python3 -m script.gen_requirements_all
..coveragerc
.To help with the load of incoming pull requests: