Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add extra sensors to Blebox #90516

Merged
merged 7 commits into from
Aug 30, 2023

Conversation

riokuu
Copy link
Contributor

@riokuu riokuu commented Mar 30, 2023

Proposed change

Added SensorDesciptors to expose more information from blebox_uniapi integration.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • I have followed the perfect PR recommendations
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
  • Untested files have been added to .coveragerc.

To help with the load of incoming pull requests:

@home-assistant
Copy link

Hey there @bbx-a, mind taking a look at this pull request as it has been labeled with an integration (blebox) you are listed as a code owner for? Thanks!

Code owner commands

Code owners of blebox can trigger bot actions by commenting:

  • @home-assistant close Closes the pull request.
  • @home-assistant rename Awesome new title Renames the pull request.
  • @home-assistant reopen Reopen the pull request.
  • @home-assistant unassign blebox Removes the current integration label and assignees on the pull request, add the integration domain after the command.

@epenet epenet changed the title Blebox: add sensor descriptorsfor wind_speed, humidity, powerMeasurement Add extra sensors to Blebox Mar 30, 2023
@bbx-a
Copy link

bbx-a commented Mar 31, 2023

Hey there @bbx-a, mind taking a look at this pull request as it has been labeled with an integration (blebox) you are listed as a code owner for? Thanks!

Code owner commands

LGTM, Thanks!

@Rexluu
Copy link

Rexluu commented May 17, 2023

hello @emontnemery, I saw that you accepted a few previous "pull requests" from @riokuu. I have a favour to ask, can you look at this? =)

It adds some nice functions to "blebox integration". I would appreciate it ("shibby20" probably too), because we both are waiting for "energy measurement".

@riokuu riokuu force-pushed the blebox_humidity_windspeed branch from b635a16 to a50a8f6 Compare June 30, 2023 06:15
Copy link
Contributor

@edenhaus edenhaus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please don't ping members, as this will not speed up the process.

Please add tests for the new functionality and make sure the CI passes.

homeassistant/components/blebox/sensor.py Outdated Show resolved Hide resolved
@home-assistant home-assistant bot marked this pull request as draft August 16, 2023 09:49
@home-assistant
Copy link

Please take a look at the requested changes, and use the Ready for review button when you are done, thanks 👍

Learn more about our pull request process.

@riokuu riokuu marked this pull request as ready for review August 28, 2023 11:31
@home-assistant home-assistant bot requested a review from edenhaus August 28, 2023 11:31
Copy link
Contributor

@edenhaus edenhaus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @riokuu 👍

@edenhaus edenhaus merged commit e911b73 into home-assistant:dev Aug 30, 2023
@github-actions github-actions bot locked and limited conversation to collaborators Aug 31, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants