-
-
Notifications
You must be signed in to change notification settings - Fork 32.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add extra sensors to Blebox #90516
Add extra sensors to Blebox #90516
Conversation
Hey there @bbx-a, mind taking a look at this pull request as it has been labeled with an integration ( Code owner commandsCode owners of
|
LGTM, Thanks! |
hello @emontnemery, I saw that you accepted a few previous "pull requests" from @riokuu. I have a favour to ask, can you look at this? =) It adds some nice functions to "blebox integration". I would appreciate it ("shibby20" probably too), because we both are waiting for "energy measurement". |
b635a16
to
a50a8f6
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please don't ping members, as this will not speed up the process.
Please add tests for the new functionality and make sure the CI passes.
Please take a look at the requested changes, and use the Ready for review button when you are done, thanks 👍 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @riokuu 👍
Proposed change
Added SensorDesciptors to expose more information from blebox_uniapi integration.
Type of change
Additional information
Checklist
black --fast homeassistant tests
)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest
.requirements_all.txt
.Updated by running
python3 -m script.gen_requirements_all
..coveragerc
.To help with the load of incoming pull requests: