Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Device tracker for o2box #890

Closed
wants to merge 6 commits into from
Closed

Device tracker for o2box #890

wants to merge 6 commits into from

Conversation

chrido
Copy link

@chrido chrido commented Jan 13, 2016

This PR adds support for the O2Box, similar to the one shown here:
https://hilfe.o2online.de/docs/DOC-1332

self.password = config[CONF_PASSWORD]

# Establish a connection to the FRITZ!Box
self.o2_box = O2Box(host=self.host, routerpassword=self.password)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What happens here if host and password are not defined in the configuration?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixed

@chrido
Copy link
Author

chrido commented Jan 14, 2016

Addressed the comments, updated to dev

@balloob
Copy link
Member

balloob commented Jan 14, 2016

Can you add your file to .coveragerc and it seems that CI reported some style violations: https://travis-ci.org/balloob/home-assistant/jobs/102450052#L187-L214

@balloob
Copy link
Member

balloob commented Feb 2, 2016

This is an automated response to help you succeed in getting this PR merged.

  • Whenever CI fails, the reason for failing will be at the bottom of the log. Each Python version performs different tests so it can be that only Python 3.5 fails. Your PR cannot be merged unless CI is green!
  • Always make sure your fork is up to date before you create a new branch. No "merge upstream" or "merge dev" commits. Also rebase on the dev branch before creating a PR.
  • Squash your commits when the PR is ready to be merged.

If your code communicates with devices:

  • Use a 3rd party library for communication. Add dependencies via REQUIREMENTS variable (example).
  • Only import your 3rd party dependencies inside functions that use it (example).
  • Run script/gen_requirements_all.py to update requirements_all.txt.
  • Add your new files to .coveragerc

If your code does not depend on external devices:

  • Write tests to verify your code works

@balloob
Copy link
Member

balloob commented Feb 16, 2016

Closing this PR as it has gone stale.

@balloob balloob closed this Feb 16, 2016
@home-assistant home-assistant locked and limited conversation to collaborators Mar 17, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants