Disable profiler.memory service with python 3.11 #88136
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
guppy3 is not python3.11 compat zhuyifei1999/guppy3#41 This service will return if and when guppy3 becomes python3.11 compat
home-assistant
bot
added
breaking-change
cla-signed
has-tests
integration: profiler
small-pr
|
We could make this conditionally available? |
Do we have a way to conditionally install the lib ? |
|
In theory, the requirement can specify a python version requirement (as per general pip stuff), not sure if our “gen_requirements_all” will swallow it right now. But yeah, we could theoretically optionally install requirements based on python version used. |
bdraco
changed the title
Merged
8 tasks
bdraco
commented
Feb 15, 2023
| @@ -90,7 +90,7 @@ def validate_requirements_format(integration: Integration) -> bool: | |||
| if not version: | |||
| continue | |||
|
|
|||
| for part in version.split(","): | |||
| for part in version.split(";", 1)[0].split(","): | |||
There was a problem hiding this comment.
Can break this out into another PR if desirable but left here initially for context
|
test failure is unrelated |
frenck
approved these changes
Feb 15, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Breaking change
The
profiler.memoryservice is not available when using python 3.11. It will return if and when guppy3 becomes python3.11 compatible.Proposed change
guppy3 is not python3.11 compatible
zhuyifei1999/guppy3#41
Type of change
Additional information
Checklist
black --fast homeassistant tests)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest.requirements_all.txt.Updated by running
python3 -m script.gen_requirements_all..coveragerc.To help with the load of incoming pull requests: