Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update orjson to resolve segmentation fault during JSON serialisation #88119

Merged
merged 1 commit into from
Feb 14, 2023

Conversation

mgjbroadbent
Copy link
Contributor

Home Assistant uses orjson 3.8.5 that contains an issue[1] on musl libc platforms that causes a segmentation fault. This particularly affect Home Assistant container installations and is reported in #87283 and #87522.

This updates the version to 3.8.6 that resolves the segmentation fault during json serialisation.

orjson changelog - https://github.com/ijl/orjson/releases/tag/3.8.6

[1] ijl/orjson#335

Proposed change

Update the orison library dependancy to 3.8.6 that has a single fix for a segmentation fault on muse libc based installations.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

Checklist

  • [ X] The code change is tested and works locally.
  • [ X] Local tests pass. Your PR cannot be merged unless tests pass
  • [ X] There is no commented out code in this PR.
  • [ X] I have followed the [development checklist][dev-checklist]
  • [ X] The code has been formatted using Black (black --fast homeassistant tests)
  • [ X] Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

  • Documentation added/updated for [www.home-assistant.io][docs-repository]

If the code communicates with devices, web services, or third-party tools:

  • The [manifest file][manifest-docs] has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • [X ] For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
  • Untested files have been added to .coveragerc.

To help with the load of incoming pull requests:

  • I have reviewed two other [open pull requests][prs] in this repository.

Home Assistant uses orjson 3.8.5 that contains an issue[1] on musl libc
platforms that causes a segmentation fault.  This particularly affect
Home Assistant container installations reported in home-assistant#87283 and home-assistant#87522.

This updates the version to 3.8.6 that resolves the segmentation
fault during json serialisation.

[1] ijl/orjson#335
@mgjbroadbent mgjbroadbent requested a review from a team as a code owner February 14, 2023 19:14
@home-assistant home-assistant bot added cla-needed core dependency small-pr PRs with less than 30 lines. labels Feb 14, 2023
@home-assistant
Copy link

Hi @mgjbroadbent

It seems you haven't yet signed a CLA. Please do so here.

Once you do that we will be able to review and accept this pull request.

Thanks!

@bdraco bdraco added this to the 2023.2.5 milestone Feb 14, 2023
@balloob balloob merged commit 568e0ae into home-assistant:dev Feb 14, 2023
balloob pushed a commit that referenced this pull request Feb 15, 2023
…#88119)

Home Assistant uses orjson 3.8.5 that contains an issue[1] on musl libc
platforms that causes a segmentation fault.  This particularly affect
Home Assistant container installations reported in #87283 and #87522.

This updates the version to 3.8.6 that resolves the segmentation
fault during json serialisation.

[1] ijl/orjson#335
@balloob balloob mentioned this pull request Feb 15, 2023
@github-actions github-actions bot locked and limited conversation to collaborators Feb 16, 2023
@mgjbroadbent mgjbroadbent deleted the update-orjson-386 branch February 28, 2023 21:11
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants