Keep task references while running #87970
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
balloob
commented
Feb 13, 2023
balloob
commented
Feb 13, 2023
Comment on lines
-642
to
-644
| while self._pending_tasks: | ||
| pending = [task for task in self._pending_tasks if not task.done()] | ||
| self._pending_tasks.clear() |
There was a problem hiding this comment.
The old approach would clear all the tasks so it would only track new tasks. The new approach is to just track all tasks. Old + new. It doesn't matter because if the old one blocks, it's also blocking. It was also necessary because each task will try to remove itself from this set once it's done.
|
Tried re-running the failed tests locally and they all pass 🙄 |
19 tasks
pvizeli
reviewed
Feb 13, 2023
balloob
force-pushed
the
keep-task-references
branch
from
de389a4 to
e642fb4
Compare
bdraco
reviewed
Feb 13, 2023
emontnemery
reviewed
Feb 13, 2023
| @@ -69,7 +69,7 @@ def setup(hass: HomeAssistant, config: ConfigType) -> bool: | |||
| else: | |||
| _LOGGER.debug("No connection check for UDP possible") | |||
|
|
|||
| GraphiteFeeder(hass, host, port, protocol, prefix) | |||
| hass.data[DOMAIN] = GraphiteFeeder(hass, host, port, protocol, prefix) | |||
There was a problem hiding this comment.
Previously the test relied on race conditions about when the thread was done with work. Now the test just wait for the thread to be done.
balloob
force-pushed
the
keep-task-references
branch
from
fb704b0 to
6fe9569
Compare
|
Testing
|
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Breaking change
Proposed change
Attempt 2 to make sure we track all tasks created in HA. This time we only track it for tasks created via
hass.async_create_taskand not for all tasks created on our event loop (which was attempt 1 at #87959)Will always track tasks but make sure tasks clean up themselves.
This feels a bit like heart surgery…
Also added a newhass.background_task.async_create_taskfor tasks you know are going to be in the background. They will never blockasync_block_till_donebut still get canceled when HA shuts down.Type of change
Additional information
Checklist
black --fast homeassistant tests)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest.requirements_all.txt.Updated by running
python3 -m script.gen_requirements_all..coveragerc.To help with the load of incoming pull requests: