Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a repair issue when using MariaDB is affected by MDEV-25020 #87040

Merged
merged 10 commits into from
Jan 31, 2023

Conversation

bdraco
Copy link
Member

@bdraco bdraco commented Jan 31, 2023

Needs to wait for the MariaDB addon to be updated from 10.6.8 to 10.6.10 since users can't do much about this if they are using the addon.

Proposed change

https://jira.mariadb.org/browse/MDEV-25020

Screenshot 2023-01-31 at 12 40 43 PM

Screenshot 2023-01-31 at 12 44 25 PM

MariaDB fixed this in 10.5.17, 10.6.9, 10.7.5, 10.8.4. Previous versions would have history and purge queries running for hours which consumed all the available I/O and could make the whole system unstable.

closes #83787

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
  • Untested files have been added to .coveragerc.

To help with the load of incoming pull requests:

…iadb.org/browse/MDEV-25020

MariaDB fixed this in 10.5.17, 10.6.9, 10.7.5, 10.8.4. Previous version
would have history and purge queries running for hours which consumed
all the available I/O and could make the whole system unstable

closes home-assistant#83787
@home-assistant
Copy link

Hey there @home-assistant/core, mind taking a look at this pull request as it has been labeled with an integration (recorder) you are listed as a code owner for? Thanks!

Code owner commands

Code owners of recorder can trigger bot actions by commenting:

  • @home-assistant close Closes the issue.
  • @home-assistant rename Awesome new title Change the title of the issue.
  • @home-assistant reopen Reopen the issue.
  • @home-assistant unassign recorder Removes the current integration label and assignees on the issue, add the integration domain after the command.

@bdraco bdraco marked this pull request as ready for review January 31, 2023 19:06
@bdraco bdraco requested a review from a team as a code owner January 31, 2023 19:06
Copy link
Member

@frenck frenck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @bdraco 👍

../Frenck

@frenck frenck merged commit 5284837 into home-assistant:dev Jan 31, 2023
@slovdahl
Copy link
Contributor

slovdahl commented Feb 1, 2023

@bdraco Just curious, have this been verified to affect MariaDB 10.3 too? Reading the MariaDB issue it sounds like it could be a regression in 10.5 and newer, but it's not really clear. 🤔

@bdraco
Copy link
Member Author

bdraco commented Feb 1, 2023

There are performance problems with purging on any version before 10.6.9. You'll probably never notice them if you have tiny database though (most people who migrated to MySQL did so because they have a large dataset though), but if your database ever grows to multi-gigabytes make sure you have 10.6.9+

@home-assistant home-assistant locked as resolved and limited conversation to collaborators Feb 1, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

History start time state query optimizes poorly with MariaDB 10.6.8
4 participants