Increase test scope of MariaDB + PostgreSQL tests #87019

emontnemery · 2023-01-31T12:34:12Z

Proposed change

Increase test scope of the MariaDB CI job

Type of change

Dependency upgrade
Bugfix (non-breaking change which fixes an issue)
New integration (thank you!)
New feature (which adds functionality to an existing integration)
Deprecation (breaking change to happen in the future)
Breaking change (fix/feature causing existing functionality to break)
Code quality improvements to existing code or addition of tests

Additional information

This PR fixes or closes issue: fixes #
This PR is related to issue:
Link to documentation pull request:

Checklist

The code change is tested and works locally.
Local tests pass. Your PR cannot be merged unless tests pass
There is no commented out code in this PR.
I have followed the development checklist
The code has been formatted using Black (black --fast homeassistant tests)
Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

Documentation added/updated for www.home-assistant.io

If the code communicates with devices, web services, or third-party tools:

The manifest file has all fields filled out correctly.
Updated and included derived files by running: python3 -m script.hassfest.
New or updated dependencies have been added to requirements_all.txt.
Updated by running python3 -m script.gen_requirements_all.
For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
Untested files have been added to .coveragerc.

To help with the load of incoming pull requests:

I have reviewed two other open pull requests in this repository.

…about order

bdraco · 2023-01-31T19:31:07Z

Cherry-picked the test fixes from #86436

This should pass now

bdraco · 2023-01-31T20:45:43Z

Looks like everything is good except for FAILED tests/components/logbook/test_websocket_api.py::test_recorder_is_far_behind - AssertionError: assert [{'domain': '...97063.376577}] == []

This appears to be a race order issue (not a production problem) in the test

.github/workflows/ci.yaml

epenet · 2023-02-09T09:22:23Z

Should we adjust .core_files.yaml to match? #87764

bdraco · 2023-02-09T09:29:11Z

There are still a few postgresql history/stats tests that need the same fixes as the recorder versions of them

epenet

I'm just marking this as requested changes - we don't want to forget to adjust .core_files.yaml and end up with unexpected issues in CI.

bdraco · 2023-02-10T23:02:56Z

Was going to work on this today but ended up doing another pass on statistics since I thought I couldn't optimize it anymore and than I came up with an idea... #87859 so I'll pick this up this weekend instead

…r is indeterminate

bdraco · 2023-02-13T16:44:34Z

postgres has two issues

delete duplicate stats is taking too long
the stats history is returning integer values (cannot replicate locally though)

hass=# select * from states limit 5;
 state_id |        entity_id        | state  | attributes | event_id | last_changed | last_updated | old_state_id | attributes_id |         context_id         | context_user_id | context_parent_id | origin_idx |  last_updated_ts  | last_changed_ts 
----------+-------------------------+--------+------------+----------+--------------+--------------+--------------+---------------+----------------------------+-----------------+-------------------+------------+-------------------+-----------------
   464804 | sensor.power_sensor_899 | 241565 |            |          |              |              |       463803 |           904 | 01GQXC3CGBWVJB9NS0KB494KTN |                 |                   |          0 | 1674949276.171689 |                
   464805 | sensor.power_sensor_900 | 394504 |            |          |              |              |       463804 |           905 | 01GQXC3CGB52ACC4FKWF0XARD4 |                 |                   |          0 | 1674949276.171708 |

bdraco · 2023-02-13T16:49:50Z

Its definitely creating the columns correctly

     1230 | lock.downstairs_guest_sliding_door                                          | locked                           |            |          |              |  1676306942.78344 |              | 1676306946.984045 |         1105 |          1097 | 01GS5TW6X8NVNW11GRPEKDCV5W |                 |                   |          0
     1231 | lock.garage_den_door                                                        | locked                           |            |          |              | 1676306942.783529 |              | 1676306949.177022 |         1109 |          1098 | 01GS5TW91S8REPEA0E00Y5D68W |                 |                   |          0
     1232 | lock.den_door                                                               | unlocked                         |            |          |              | 1676306942.783509 |              | 1676306952.221956 |         1108 |          1146 | 01GS5TWC0X19ADB35KPJK1J12C |                 |                   |          0
     1233 | lock.garage_main_entry_door                                                 | locked                           |            |          |              | 1676306942.783467 |              | 1676306952.468899 |         1106 |          1147 | 01GS5TWC8MSP

bdraco · 2023-02-13T16:50:17Z

but the raw data all comes back with .0

[('sensor.test1', '-10', None, 1630472405.0, None, '{"device_class":null,"state_class":"measurement","unit_of_measurement":"%"}'),
 ('sensor.test1', '15', None, 1630472455.0, None, '{"device_class":null,"state_class":"measurement","unit_of_measurement":"%"}'),
 ('sensor.test1', '30', None, 1630472655.0, None, '{"device_class":null,"state_class":"measurement","unit_of_measurement":"%"}'),
 ('sensor.test1', '-10', None, 1630472705.0, None, '{"device_class":null,"state_class":"measurement","unit_of_measurement":"%"}'),
 ('sensor.test1', '15', None, 1630472755.0, None, '{"device_class":null,"state_class":"measurement","unit_of_measurement":"%"}'),
 ('sensor.test1', '30', None, 1630472955.0, None, '{"device_class":null,"state_class":"measurement","unit_of_measurement":"%"}'),
 ('sensor.test1', '-10', None, 1630473005.0, None, '{"device_class":null,"state_class":"measurement","unit_of_measurement":"%"}'),
 ('sensor.test1', '15', None, 1630473055.0, None, '{"device_class":null,"state_class":"measurement","unit_of_measurement":"%"}'),
 ('sensor.test1', '30', None, 1630473255.0, None, '{"device_class":null,"state_class":"measurement","unit_of_measurement":"%"}'),

bdraco · 2023-02-13T16:53:13Z

CREATE TABLE states (
	state_id INTEGER GENERATED BY DEFAULT AS IDENTITY, 
	entity_id VARCHAR(255), 
	state VARCHAR(255), 
	attributes TEXT, 
	event_id INTEGER, 
	last_changed TIMESTAMP WITH TIME ZONE, 
	last_changed_ts DOUBLE PRECISION, 
	last_updated TIMESTAMP WITH TIME ZONE, 
	last_updated_ts DOUBLE PRECISION, 
	old_state_id INTEGER, 
	attributes_id INTEGER, 
	context_id VARCHAR(36), 
	context_user_id VARCHAR(36), 
	context_parent_id VARCHAR(36), 
	origin_idx SMALLINT, 
	PRIMARY KEY (state_id), 
	FOREIGN KEY(event_id) REFERENCES events (event_id) ON DELETE CASCADE, 
	FOREIGN KEY(old_state_id) REFERENCES states (state_id), 
	FOREIGN KEY(attributes_id) REFERENCES state_attributes (attributes_id)
)

Its being created correctly

bdraco · 2023-02-13T17:05:51Z

 ('sensor.test4', '22.75', None, 1630479060.0, None, '{"device_class":null,"state_class":"total","unit_of_measurement":"EUR"}'),
 ('sensor.test4', '22.5', None, 1630479060.0, None, '{"device_class":null,"state_class":"total","unit_of_measurement":"EUR"}'),
 ('sensor.test4', '23', None, 1630479300.0, None, '{"device_class":null,"state_class":"total","unit_of_measurement":"EUR"}'),
 ('sensor.test4', '23.75', None, 1630479360.0, None, '{"device_class":null,"state_class":"total","unit_of_measurement":"EUR"}'),
 ('sensor.test4', '23.5', None, 1630479360.0, None, '{"device_class":null,"state_class":"total","unit_of_measurement":"EUR"}')]

some other data it out of order as well for postgresql.

but only sensor.test4

bdraco · 2023-02-13T17:10:55Z

they are being recorded at the same time

 ('sensor.test4', '23.75', None, 1630479360.0, None, '{"device_class":null,"state_class":"total","unit_of_measurement":"EUR"}'),
 ('sensor.test4', '23.5', None, 1630479360.0, None, '{"device_class":null,"state_class":"total","unit_of_measurement":"EUR"}')]

bdraco · 2023-02-13T17:12:42Z

DEBUG:homeassistant.core:Bus:Handling <Event state_changed[L]: entity_id=sensor.test4, old_state=<state sensor.test4=0; device_class=None, state_class=total, unit_of_measurement=EUR @ 2021-08-31T23:00:00-06:00>, new_state=<state sensor.test4=0.5; device_class=None, state_class=total, unit_of_measurement=EUR @ 2021-08-31T23:01:00-06:00>>
DEBUG:homeassistant.core:Bus:Handling <Event state_changed[L]: entity_id=sensor.test4, old_state=<state sensor.test4=0.5; device_class=None, state_class=total, unit_of_measurement=EUR @ 2021-08-31T23:01:00-06:00>, new_state=<state sensor.test4=0.75; device_class=None, state_class=total, unit_of_measurement=EUR @ 2021-08-31T23:01:00-06:00>>

So not the database

bdraco · 2023-02-13T17:32:27Z

tests/components/sensor/test_recorder.py

@@ -3094,7 +3094,7 @@ def _sum(seq, last_state, last_sum):
                sum_attributes,
                seq[j : j + 1],
            )
-            start_meter = start + timedelta(minutes=1)
+            start_meter += timedelta(minutes=1)


This was a bug in the test, it was inserting rows with the same timestamp down to the microsecond so selecting them back resulted in an indeterminate order

bdraco · 2023-02-13T17:33:02Z

There were no functional changes here. So it looks like our code is good, we just needed to fix some tests 👍

epenet

LGTM 👍

bdraco · 2023-02-13T21:58:19Z

Thanks

Increase test scope of mariadb tests

867a01a

home-assistant bot added cla-signed small-pr PRs with less than 30 lines. labels Jan 31, 2023

bdraco added 2 commits January 31, 2023 13:23

fix test to only check which entities are returned as we do not care …

555c70b

…about order

fix test to only check which entities are returned as we do not care …

77f11ba

…about order

bdraco approved these changes Jan 31, 2023

View reviewed changes

bdraco requested a review from a team as a code owner January 31, 2023 19:23

Merge branch 'dev' into mariadb_tests_increase_scope

9b17dde

bdraco closed this Jan 31, 2023

bdraco reopened this Jan 31, 2023

Merge branch 'dev' into mariadb_tests_increase_scope

43c049e

emontnemery closed this Feb 9, 2023

emontnemery reopened this Feb 9, 2023

epenet reviewed Feb 9, 2023

View reviewed changes

.github/workflows/ci.yaml Show resolved Hide resolved

frenck marked this pull request as draft February 9, 2023 07:41

emontnemery changed the title ~~Increase test scope of mariadb tests~~ Increase test scope of MariaDB + PostgreSQL tests Feb 9, 2023

Increase test scope also of for the postgres job

c0fb737

emontnemery marked this pull request as ready for review February 9, 2023 07:45

bdraco marked this pull request as draft February 9, 2023 09:28

epenet requested changes Feb 10, 2023

View reviewed changes

bdraco self-assigned this Feb 10, 2023

bdraco added database: mariadb database: postgresql labels Feb 13, 2023

bdraco added 2 commits February 13, 2023 09:53

Merge branch 'dev' into mariadb_tests_increase_scope

2ca1180

adjust test for mysql timings

4cd4f78

more fixes for tests that fire at the exact same microsecond and orde…

bcc520f

…r is indeterminate

bdraco added 2 commits February 13, 2023 11:27

fix bug in test that was inserting rows with the exact same timestamp

d91ed03

speed up test

9ce07ea

bdraco reviewed Feb 13, 2023

View reviewed changes

bdraco marked this pull request as ready for review February 13, 2023 17:33

bdraco added 2 commits February 13, 2023 11:36

adjust .core_files

c596a4e

adjust .core_files

2179114

bdraco approved these changes Feb 13, 2023

View reviewed changes

bdraco requested a review from epenet February 13, 2023 17:37

epenet approved these changes Feb 13, 2023

View reviewed changes

bdraco merged commit 4ca0a24 into dev Feb 13, 2023

bdraco deleted the mariadb_tests_increase_scope branch February 13, 2023 21:58

github-actions bot locked and limited conversation to collaborators Feb 14, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Increase test scope of MariaDB + PostgreSQL tests #87019

Increase test scope of MariaDB + PostgreSQL tests #87019

emontnemery commented Jan 31, 2023 •

edited by bdraco

Loading

bdraco commented Jan 31, 2023

bdraco commented Jan 31, 2023

epenet commented Feb 9, 2023

bdraco commented Feb 9, 2023

epenet left a comment •

edited

Loading

bdraco commented Feb 10, 2023

bdraco commented Feb 13, 2023 •

edited

Loading

bdraco commented Feb 13, 2023

bdraco commented Feb 13, 2023

bdraco commented Feb 13, 2023

bdraco commented Feb 13, 2023

bdraco commented Feb 13, 2023

bdraco commented Feb 13, 2023

bdraco Feb 13, 2023

bdraco commented Feb 13, 2023

epenet left a comment

bdraco commented Feb 13, 2023

Increase test scope of MariaDB + PostgreSQL tests #87019

Increase test scope of MariaDB + PostgreSQL tests #87019

Conversation

emontnemery commented Jan 31, 2023 • edited by bdraco Loading

Proposed change

Type of change

Additional information

Checklist

bdraco commented Jan 31, 2023

bdraco commented Jan 31, 2023

epenet commented Feb 9, 2023

bdraco commented Feb 9, 2023

epenet left a comment • edited Loading

Choose a reason for hiding this comment

bdraco commented Feb 10, 2023

bdraco commented Feb 13, 2023 • edited Loading

bdraco commented Feb 13, 2023

bdraco commented Feb 13, 2023

bdraco commented Feb 13, 2023

bdraco commented Feb 13, 2023

bdraco commented Feb 13, 2023

bdraco commented Feb 13, 2023

bdraco Feb 13, 2023

Choose a reason for hiding this comment

bdraco commented Feb 13, 2023

epenet left a comment

Choose a reason for hiding this comment

bdraco commented Feb 13, 2023

emontnemery commented Jan 31, 2023 •

edited by bdraco

Loading

epenet left a comment •

edited

Loading

bdraco commented Feb 13, 2023 •

edited

Loading