-
-
Notifications
You must be signed in to change notification settings - Fork 32.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Honeywell Correct key name #87018
Honeywell Correct key name #87018
Conversation
Hey there @rdfurman, mind taking a look at this pull request as it has been labeled with an integration ( Code owner commandsCode owners of
|
should this be tagged for the beta? Also, how come we are changing the same attribute names 2 PRs in a row. Are you sure it's correct? |
This probably should be in the beta - I broke some things I miss understood. |
* Correct key name * Logic error around setpoint and auto mode * Set tempurature and setpoints correctly * Only high/low in auto.
Tested and works well. |
Proposed change
Fix incorrectly capitalized key names
Revert limit settings to original, add try.
Set setpoints back into auto
Type of change
Additional information
Checklist
black --fast homeassistant tests
)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest
.requirements_all.txt
.Updated by running
python3 -m script.gen_requirements_all
..coveragerc
.To help with the load of incoming pull requests: