Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Honeywell Correct key name #87018

Merged
merged 4 commits into from
Jan 31, 2023
Merged

Honeywell Correct key name #87018

merged 4 commits into from
Jan 31, 2023

Conversation

mkmer
Copy link
Contributor

@mkmer mkmer commented Jan 31, 2023

Proposed change

Fix incorrectly capitalized key names
Revert limit settings to original, add try.
Set setpoints back into auto

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
  • Untested files have been added to .coveragerc.

To help with the load of incoming pull requests:

@home-assistant
Copy link

Hey there @rdfurman, mind taking a look at this pull request as it has been labeled with an integration (honeywell) you are listed as a code owner for? Thanks!

Code owner commands

Code owners of honeywell can trigger bot actions by commenting:

  • @home-assistant close Closes the issue.
  • @home-assistant rename Awesome new title Change the title of the issue.
  • @home-assistant reopen Reopen the issue.
  • @home-assistant unassign honeywell Removes the current integration label and assignees on the issue, add the integration domain after the command.

@mkmer mkmer marked this pull request as draft January 31, 2023 13:31
@mkmer mkmer marked this pull request as ready for review January 31, 2023 14:40
@balloob
Copy link
Member

balloob commented Jan 31, 2023

should this be tagged for the beta?

Also, how come we are changing the same attribute names 2 PRs in a row. Are you sure it's correct?

@mkmer
Copy link
Contributor Author

mkmer commented Jan 31, 2023

This probably should be in the beta - I broke some things I miss understood.
The original problem statement was related to elif and NOT the _set_temperature() function logic.
The attribute fix was run through the capitalize() function NOT capital the whole name :( Should have been Heat/Cool not HEAT/COOL.
This thermostat is a bit "weird" - if it's in auto mode, the heat/cool set points are the low and high targets, but if it's in cool or heat the respective values are direct set points for the set mode.
I found the errors when I merged the changes into the testing branch. Sure reinforces the value of tests!
Sorry about the back and forth.

@balloob balloob added this to the 2023.2.0 milestone Jan 31, 2023
@balloob balloob merged commit ee30f5a into home-assistant:dev Jan 31, 2023
@mkmer mkmer deleted the Correct_KeyName branch January 31, 2023 18:00
balloob pushed a commit that referenced this pull request Jan 31, 2023
* Correct key name

* Logic error around setpoint and auto mode

* Set tempurature and setpoints correctly

* Only high/low in auto.
@reotto613
Copy link

Tested and works well.

@github-actions github-actions bot locked and limited conversation to collaborators Feb 1, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Honeywell Total Connect Comfort Preset Away Mode and Target Temps
3 participants