Remove lumen from Illuminance units

[epenet]

Breaking change

For developpers only: lm is no longer allowed as a unit for sensors with Illuminance device class.

Proposed change

Linked to home-assistant/architecture#843

• dev docs Remove lumen from Illuminance units developers.home-assistant#1592
• docs Remove lumen from Illuminance units home-assistant.io#25378

Type of change

• Dependency upgrade
• Bugfix (non-breaking change which fixes an issue)
• New integration (thank you!)
• New feature (which adds functionality to an existing integration)
• Deprecation (breaking change to happen in the future)
• Breaking change (fix/feature causing existing functionality to break)
• Code quality improvements to existing code or addition of tests

Additional information

• This PR fixes or closes issue: fixes #
• This PR is related to issue:
• Link to documentation pull request:

Checklist

• The code change is tested and works locally.
• Local tests pass. Your PR cannot be merged unless tests pass
• There is no commented out code in this PR.
• I have followed the development checklist
• The code has been formatted using Black (black --fast homeassistant tests)
• Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

• Documentation added/updated for www.home-assistant.io

If the code communicates with devices, web services, or third-party tools:

• The manifest file has all fields filled out correctly.
  Updated and included derived files by running: python3 -m script.hassfest.
• New or updated dependencies have been added to requirements_all.txt.
  Updated by running python3 -m script.gen_requirements_all.
• For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
• Untested files have been added to .coveragerc.

To help with the load of incoming pull requests:

• I have reviewed two other open pull requests in this repository.

[home-assistant]

Hey there @home-assistant/core, mind taking a look at this pull request as it has been labeled with an integration (sensor) you are listed as a code owner for? Thanks!

Code owner commands

Code owners of sensor can trigger bot actions by commenting:

• @home-assistant close Closes the issue.
• @home-assistant rename Awesome new title Change the title of the issue.
• @home-assistant reopen Reopen the issue.
• @home-assistant unassign sensor Removes the current integration label and assignees on the issue, add the integration domain after the command.

[home-assistant]

Hey there @home-assistant/core, @Shulyaka, mind taking a look at this pull request as it has been labeled with an integration (number) you are listed as a code owner for? Thanks!

Code owner commands

Code owners of number can trigger bot actions by commenting:

• @home-assistant close Closes the issue.
• @home-assistant rename Awesome new title Change the title of the issue.
• @home-assistant reopen Reopen the issue.
• @home-assistant unassign number Removes the current integration label and assignees on the issue, add the integration domain after the command.

[frenck]

The affected integrations need to be cleaned up too.

These are (as it seems):

• Plugwise
• Xiaomi Miio
• HomeKit

Additionally, our custom test component uses "lm" as a unit of measurement for this device class, which needs to be adjusted too.

[MartinHjelmare]

Here's another one:

core/homeassistant/components/tuya/const.py

Lines 459 to 463 in a701630

	UnitOfMeasurement(
	unit="lm",
	aliases={"lum", "lumen"},
	device_classes={SensorDeviceClass.ILLUMINANCE},
	),

[epenet]

Not sure how to cleanup tuya. Should I be removing the whole UnitOfMeasurement entry? Or should I just be clearing the device_classes set?

[frenck]

Not sure how to cleanup tuya. Should I be removing the whole UnitOfMeasurement entry? Or should I just be clearing the device_classes set?

Yup! 👍

[epenet]

Not sure how to cleanup tuya. Should I be removing the whole UnitOfMeasurement entry? Or should I just be clearing the device_classes set?

Yup! 👍

Was that a "yup" to remove the whole UnitOfMeasurement entry? (as I did)
Or was that a "yup" to only clear the device_classes set? (in which case I need to bring the UnitOfMeasurement entry back in)

[frenck]

The "yup" was the removal, your last commit is correct 👍

[frenck]

Thanks, @epenet 👍