Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Raise UpdateFailed when here_travel_time cannot find_location #83157

Merged
merged 2 commits into from
Dec 3, 2022

Conversation

eifinger
Copy link
Contributor

@eifinger eifinger commented Dec 2, 2022

Proposed change

Fixes #83100

Properly raise an UpdateFailed and provide more information.
The integration now starts later, to give sensors and other entities it might depend or more time to finish set up.

I tried to use self.coordinator.async_config_entry_first_refresh instead of self.async_update here but this led to a lot of failing tests due to uncaught errors. I tried to use with pytest.raises but with no effect.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
  • Untested files have been added to .coveragerc.

To help with the load of incoming pull requests:

@eifinger
Copy link
Contributor Author

eifinger commented Dec 2, 2022

Found a way using async_config_entry_first_refresh but have a conflict with state restoration

@balloob balloob added this to the 2022.12.0 milestone Dec 3, 2022
@eifinger eifinger marked this pull request as ready for review December 3, 2022 08:01
@eifinger
Copy link
Contributor Author

eifinger commented Dec 3, 2022

Found a way using async_config_entry_first_refresh but have a conflict with state restoration

I removed the Draft state. The current solution definately fixes the issue. If using async_config_entry_first_refresh turns out to be even more of an improvement I will open a follow up PR.

@balloob balloob merged commit f88d22b into home-assistant:dev Dec 3, 2022
balloob pushed a commit that referenced this pull request Dec 3, 2022
@github-actions github-actions bot locked and limited conversation to collaborators Dec 4, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Here travel time: unknown are not valid coordinates
2 participants