KNX Config/OptionsFlow: Test connection to manually configured tunnel #82872
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hey there @Julius2342, @marvin-w, mind taking a look at this pull request as it has been labeled with an integration ( Code owner commandsCode owners of
|
farmio
force-pushed
the
knx_flow_tunnel_validate
branch
from
3a6fecf to
71156df
Compare
farmio
force-pushed
the
knx_flow_tunnel_validate
branch
from
f77104b to
3dd466b
Compare
marvin-w
approved these changes
Dec 3, 2022
| @@ -908,6 +1070,7 @@ async def test_options_flow_connection_type( | |||
| gateway = _gateway_descriptor("192.168.0.1", 3675) | |||
|
|
|||
| await hass.config_entries.async_setup(mock_config_entry.entry_id) | |||
| hass.data[DOMAIN] = Mock() # GatewayScanner uses running XKNX() in options flow | |||
There was a problem hiding this comment.
If we need the integration setup, set up the integration without patching the integration setup function. Just patch the library. Never set things in hass.data in tests.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed change
🔐because its cute 😃Type of change
Additional information
Checklist
black --fast homeassistant tests)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest.requirements_all.txt.Updated by running
python3 -m script.gen_requirements_all..coveragerc.To help with the load of incoming pull requests: