Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix ibeacon source attribute not being updated #81740

Merged

Conversation

multigcs
Copy link
Contributor

@multigcs multigcs commented Nov 7, 2022

Proposed change

This PR will update the source attribute of iBeacons if it changes

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

iBeacon source attribute will not change/updated if i move the iBeacon into another room with another 'esp32_ble_tracker/bluetooth_proxy'

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
  • Untested files have been added to .coveragerc.

To help with the load of incoming pull requests:

@home-assistant
Copy link

home-assistant bot commented Nov 7, 2022

Hi multigcs

It seems you haven't yet signed a CLA. Please do so here.

Once you do that we will be able to review and accept this pull request.

Thanks!

@home-assistant
Copy link

home-assistant bot commented Nov 7, 2022

Hey there @bdraco, mind taking a look at this pull request as it has been labeled with an integration (ibeacon) you are listed as a code owner for? Thanks!

Code owner commands

Code owners of ibeacon can trigger bot actions by commenting:

  • @home-assistant close Closes the issue.
  • @home-assistant rename Awesome new title Change the title of the issue.
  • @home-assistant reopen Reopen the issue.
  • @home-assistant unassign ibeacon Removes the current integration label and assignees on the issue, add the integration domain after the command.

Copy link
Member

@bdraco bdraco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix.

Please sign the cla and add a test for this case 👍

@MartinHjelmare MartinHjelmare changed the title ibeacon: fixing source attribute change Fix ibeacon source attribute change Nov 7, 2022
@multigcs
Copy link
Contributor Author

multigcs commented Nov 7, 2022

I can not write a good test for this PR, because 'inject_bluetooth_service_info' do not support the 'source' attribute.
I think, to do this, i must change the external 'bleak' package :(

@bdraco
Copy link
Member

bdraco commented Nov 7, 2022

Use inject_advertisement_with_time_and_source_connectable instead as inject_bluetooth_service_info is a convenience method to avoid writing out the same code over and over in the tests.

def inject_advertisement_with_time_and_source_connectable(

@bdraco bdraco changed the title Fix ibeacon source attribute change Fix ibeacon source attribute not being updated Nov 8, 2022
@bdraco bdraco added this to the 2022.11.3 milestone Nov 8, 2022
Copy link
Member

@bdraco bdraco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Manual testing looks good 👍

Thanks @multigcs

@bdraco bdraco merged commit bd28483 into home-assistant:dev Nov 13, 2022
@github-actions github-actions bot locked and limited conversation to collaborators Nov 14, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

iBeacon source attribute will not updated
3 participants