Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Save last target temperature in Shelly climate platform #80561

Merged
merged 1 commit into from
Oct 18, 2022
Merged

Save last target temperature in Shelly climate platform #80561

merged 1 commit into from
Oct 18, 2022

Conversation

bieniu
Copy link
Member

@bieniu bieniu commented Oct 18, 2022

Breaking change

Proposed change

Currently, target temperature value 4 means HVACMode OFF. When the mode is changed to HEAT, the target temperature is not changed, so the mode returns to mode OFF.
The change introduces the variable _last_target_temp, (with defaults value 20), target temperature is stored in this variable. When the HEAT mode is activated, the target temperature is set from this variable.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
  • Untested files have been added to .coveragerc.

To help with the load of incoming pull requests:

@home-assistant
Copy link

Hey there @balloob, @thecode, @chemelli74, mind taking a look at this pull request as it has been labeled with an integration (shelly) you are listed as a code owner for? Thanks!

Copy link
Member

@thecode thecode left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@thecode thecode added this to the 2022.10.5 milestone Oct 18, 2022
@thecode thecode merged commit 1b130eb into home-assistant:dev Oct 18, 2022
@bieniu bieniu deleted the shelly-climate-temp branch October 19, 2022 04:42
@github-actions github-actions bot locked and limited conversation to collaborators Oct 20, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Shelly TRV HVAC operation mode cannot be turned to "heating"
4 participants