Fix Intellifire UDP timeout

[jeeftor]

Proposed change

Update the backing library to version 2.2.1 which uses a correct UDP timeout value for socket receive. It will return an empty discovery list upon timeout - which will then let the user enter an IP of their choice:

All changes can be seen here:
jeeftor/intellifire4py@2.0.1...2.2.1

I've rewritten the AsyncUDPFireplaceFinder class to utilize asyncio.create_datagram_endpoint which hopefully will fix the existing bug we ran into.

Timeout for fireplace discovery is now changed to 12 seconds.

Type of change

• Dependency upgrade
• Bugfix (non-breaking change which fixes an issue)
• New integration (thank you!)
• New feature (which adds functionality to an existing integration)
• Deprecation (breaking change to happen in the future)
• Breaking change (fix/feature causing existing functionality to break)
• Code quality improvements to existing code or addition of tests

Additional information

• This PR fixes or closes issue: fixes Intellifire UDP Timeout error - Causing HA to crash #80202
• This PR is related to issue:
• Link to documentation pull request:

Checklist

• The code change is tested and works locally.
• Local tests pass. Your PR cannot be merged unless tests pass
• There is no commented out code in this PR.
• I have followed the development checklist
• The code has been formatted using Black (black --fast homeassistant tests)
• Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

• Documentation added/updated for www.home-assistant.io

If the code communicates with devices, web services, or third-party tools:

• The manifest file has all fields filled out correctly.
  Updated and included derived files by running: python3 -m script.hassfest.
• New or updated dependencies have been added to requirements_all.txt.
  Updated by running python3 -m script.gen_requirements_all.
• For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
• Untested files have been added to .coveragerc.

The integration reached or maintains the following Integration Quality Scale:

• No score or internal
• 🥈 Silver
• 🥇 Gold
• 🏆 Platinum

To help with the load of incoming pull requests:

• I have reviewed two other open pull requests in this repository.

[bdraco]

It looks like the library is doing blocking recv aka I/O in jeeftor/intellifire4py@2.0.1...2.1.1#diff-fc920c359ade158eaf9781217560dc1d6cb5ad59038a88f3ed5c116b8ecbb80bR61

Ideally this would get converted to an asyncio.Protocol and you can use loop.create_datagram_endpoint()

[jeeftor]

@bdraco - you are a wealth of knowledge... I'll look into how to do that :)

[jeeftor]

That being said - in the short term -> Think we could still get this patch in to the core - so I can help a user who can't install the integration because their network is doing something to UDP traffic?

[bdraco]

That being said - in the short term -> Think we could still get this patch in to the core - so I can help a user who can't install the integration because their network is doing something to UDP traffic?

I think there is a much larger risk of blocking the event loop since if the recvfrom does end up blocking its going to be for up to 15s (or longer)

Here are few examples you can borrow

https://github.com/bdraco/discovery30303/blob/master/discovery30303/__init__.py

or something more complex:
https://github.com/Danielhiversen/flux_led/blob/master/flux_led/aioscanner.py

[bdraco]

The screen logic and unifi-discovery libraries have more examples as well

[jeeftor]

@bdraco - Thanks for the pointers. I believe I have it using asyncio fully

[bdraco]

Thanks 👍

[bdraco]

@jeeftor Unrelated to this PR, but you can generally switch out asyncio.wait_for with the async_timeout and it will be much faster and less race prone