Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Philips Hue motion sensor config entities to ZHA #79923

Conversation

TheJulianJES
Copy link
Member

@TheJulianJES TheJulianJES commented Oct 9, 2022

Proposed change

Entities will only show up after the following PR has been merged:

Adds the config entities for all Philips Hue motion sensors to ZHA:

  • Sensitivity Select
  • Trigger Indicator LED Switch (this will only show up with an update of zhaquirks):
    (shows the following warning without a dependency bump:
    WARNING (MainThread) [homeassistant.components.zha.core.channels.base] [0xA5A9:2:0x0000]: 'async_initialize' stage failed: 'trigger_indicator')

Since Philips/Signify decided to add all the custom configuration entities to existing clusters, this code isn't as clean as I hoped it would be, but I think it can't be improved much at the moment(?)

I've also copied possible non-empty (?) ZCL_INIT_ATTRS. The existing config entities "override" this (since they're all for manufacturer specific clusters/channels where no other attributes exist).
So I'm not 100% sure if this needs to be done but wanted to be safe for now.

Note: Philips Hue motion sensors also support a custom timeout with the standard pir_o_to_u_delay (0x10) attribute on the Occupancy cluster. This wasn't added in this PR, as I wanted to keep this specific to Hue's custom attributes for now. A future PR could add a config entity for that attribute for all supported devices (although I'm not sure if any other devices actually use that attribute).

This was tested using a Hue in-door v2 (SML003) motion sensor:
Hue motion sensor config entities

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
  • Untested files have been added to .coveragerc.

The integration reached or maintains the following Integration Quality Scale:

  • No score or internal
  • 🥈 Silver
  • 🥇 Gold
  • 🏆 Platinum

To help with the load of incoming pull requests:

@homeassistant
Copy link
Contributor

Hey there @dmulcahey, @Adminiuga, @puddly, mind taking a look at this pull request as it has been labeled with an integration (zha) you are listed as a code owner for? Thanks!

@TheJulianJES TheJulianJES marked this pull request as ready for review October 17, 2022 21:30
@dmulcahey dmulcahey merged commit 00b0fa6 into home-assistant:dev Oct 22, 2022
@github-actions github-actions bot locked and limited conversation to collaborators Oct 23, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants