-
-
Notifications
You must be signed in to change notification settings - Fork 31.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Philips Hue motion sensor config entities to ZHA #79923
Merged
dmulcahey
merged 7 commits into
home-assistant:dev
from
TheJulianJES:tjj/zha_add_hue_motion_config_entities
Oct 22, 2022
Merged
Add Philips Hue motion sensor config entities to ZHA #79923
dmulcahey
merged 7 commits into
home-assistant:dev
from
TheJulianJES:tjj/zha_add_hue_motion_config_entities
Oct 22, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Hey there @dmulcahey, @Adminiuga, @puddly, mind taking a look at this pull request as it has been labeled with an integration ( |
veleek
reviewed
Oct 9, 2022
veleek
approved these changes
Oct 9, 2022
dmulcahey
requested changes
Oct 10, 2022
dmulcahey
approved these changes
Oct 22, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed change
Entities will only show up after the following PR has been merged:
Adds the config entities for all Philips Hue motion sensors to ZHA:
zhaquirks
):(shows the following warning without a dependency bump:
WARNING (MainThread) [homeassistant.components.zha.core.channels.base] [0xA5A9:2:0x0000]: 'async_initialize' stage failed: 'trigger_indicator'
)Since Philips/Signify decided to add all the custom configuration entities to existing clusters, this code isn't as clean as I hoped it would be, but I think it can't be improved much at the moment(?)
I've also copied possible non-empty (?)
ZCL_INIT_ATTRS
. The existing config entities "override" this (since they're all for manufacturer specific clusters/channels where no other attributes exist).So I'm not 100% sure if this needs to be done but wanted to be safe for now.
Note: Philips Hue motion sensors also support a custom timeout with the standard
pir_o_to_u_delay
(0x10) attribute on the Occupancy cluster. This wasn't added in this PR, as I wanted to keep this specific to Hue's custom attributes for now. A future PR could add a config entity for that attribute for all supported devices (although I'm not sure if any other devices actually use that attribute).This was tested using a Hue in-door v2 (
SML003
) motion sensor:Type of change
Additional information
Checklist
black --fast homeassistant tests
)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest
.requirements_all.txt
.Updated by running
python3 -m script.gen_requirements_all
..coveragerc
.The integration reached or maintains the following Integration Quality Scale:
To help with the load of incoming pull requests: