Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add device tracker to Subaru integration #79492

Merged
merged 8 commits into from
Aug 5, 2023

Conversation

G-Two
Copy link
Contributor

@G-Two G-Two commented Oct 2, 2022

Proposed change

  • Add device tracker platform to Subaru integration

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
  • Untested files have been added to .coveragerc.

The integration reached or maintains the following Integration Quality Scale:

  • No score or internal
  • 🥈 Silver
  • 🥇 Gold
  • 🏆 Platinum

To help with the load of incoming pull requests:

@vondruska
Copy link

I know this has been hanging out for a while. The code looks good to me. Are there tests to be able to add or exclude it from coverage in .coveragerc?

@G-Two G-Two force-pushed the add_device_tracker branch 2 times, most recently from 3216773 to 1ea1432 Compare March 4, 2023 23:37
Copy link
Contributor

@Lash-L Lash-L left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

I'll try to test this sometime tomorrow just so the core maintainers have another data point that it is functional. Would love to see this feature merged in. Thank you!

homeassistant/components/subaru/device_tracker.py Outdated Show resolved Hide resolved
homeassistant/components/subaru/device_tracker.py Outdated Show resolved Hide resolved
@gjohansson-ST
Copy link
Member

gjohansson-ST commented Jun 20, 2023

Setting as draft until review comments has been addressed

@gjohansson-ST gjohansson-ST marked this pull request as draft June 20, 2023 21:06
@G-Two G-Two force-pushed the add_device_tracker branch 2 times, most recently from 7bc2dee to e528769 Compare July 2, 2023 18:41
@G-Two
Copy link
Contributor Author

G-Two commented Jul 2, 2023

Comments have been addressed and branch rebased.

@G-Two G-Two marked this pull request as ready for review July 2, 2023 23:07
homeassistant/components/subaru/device_tracker.py Outdated Show resolved Hide resolved
homeassistant/components/subaru/device_tracker.py Outdated Show resolved Hide resolved
homeassistant/components/subaru/device_tracker.py Outdated Show resolved Hide resolved
homeassistant/components/subaru/device_tracker.py Outdated Show resolved Hide resolved
@home-assistant
Copy link

Please take a look at the requested changes, and use the Ready for review button when you are done, thanks 👍

Learn more about our pull request process.

@home-assistant home-assistant bot marked this pull request as draft July 29, 2023 15:55
@G-Two G-Two marked this pull request as ready for review July 29, 2023 17:45
@home-assistant home-assistant bot requested a review from gjohansson-ST July 29, 2023 17:45
@G-Two G-Two force-pushed the add_device_tracker branch from 49c185a to dbb292d Compare July 29, 2023 19:29
@gjohansson-ST
Copy link
Member

gjohansson-ST commented Jul 30, 2023

Looks finished to me besides I think you can add a test to bring coverage to 100%
Meaning test if latitude, longitude and timestamp is None

Copy link
Member

@gjohansson-ST gjohansson-ST left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@gjohansson-ST gjohansson-ST merged commit c5e5567 into home-assistant:dev Aug 5, 2023
@github-actions github-actions bot locked and limited conversation to collaborators Aug 6, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants