-
-
Notifications
You must be signed in to change notification settings - Fork 32.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add device tracker to Subaru integration #79492
Conversation
ae86aec
to
b3ef458
Compare
I know this has been hanging out for a while. The code looks good to me. Are there tests to be able to add or exclude it from coverage in |
3216773
to
1ea1432
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me!
I'll try to test this sometime tomorrow just so the core maintainers have another data point that it is functional. Would love to see this feature merged in. Thank you!
Setting as draft until review comments has been addressed |
7bc2dee
to
e528769
Compare
Comments have been addressed and branch rebased. |
Please take a look at the requested changes, and use the Ready for review button when you are done, thanks 👍 |
49c185a
to
dbb292d
Compare
Looks finished to me besides I think you can add a test to bring coverage to 100% |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍
Proposed change
Type of change
Additional information
Checklist
black --fast homeassistant tests
)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest
.requirements_all.txt
.Updated by running
python3 -m script.gen_requirements_all
..coveragerc
.The integration reached or maintains the following Integration Quality Scale:
To help with the load of incoming pull requests: