Fix acmeda set cover tilt position #76927
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
probot-home-assistant
bot
added
bugfix
integration: acmeda
small-pr
|
Hey there @atmurray, mind taking a look at this pull request as it has been labeled with an integration ( |
epenet
commented
Aug 17, 2022
| @@ -122,6 +123,6 @@ async def async_stop_cover_tilt(self, **kwargs: Any) -> None: | |||
| """Stop the roller.""" | |||
| await self.roller.move_stop() | |||
|
|
|||
| async def async_set_cover_tilt(self, **kwargs): | |||
| async def async_set_cover_tilt_position(self, **kwargs: Any) -> None: | |||
There was a problem hiding this comment.
I spotted this whilst working on pylint plugin.
I'm pretty sure this was a bug, with the function name incorrect.
epenet
added
the
smash
frenck
approved these changes
Aug 17, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed change
Fix acmeda set cover tilt position
Type of change
Additional information
Checklist
black --fast homeassistant tests)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest.requirements_all.txt.Updated by running
python3 -m script.gen_requirements_all..coveragerc.The integration reached or maintains the following Integration Quality Scale:
To help with the load of incoming pull requests: