Round up for stream record lookback #75580
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed change
#73604 modified the stream lookback behavior to avoid duplicate segments which occur under certain conditions, allowing recordings to work ahead of #73478, but those two PRs taken together may cause stream recordings to start slightly late when those duplicate segments do not occur. For example, when lookback is small (0 <= lookback <= target_duration) and the worker is already running, the in progress segment may be in the
HLSStreamOutput
and not in theRecorderOutput
. However, since the current code rounds down when calculatingnum_segments
,num_segments
comes out to 0 and thus none of the in progress segment is ever captured.This PR modifies the stream recorder to always round up 1 segment when the stream is already active. While the lookback calculation is still inexact, it is better to include more data than to miss some.
Type of change
Additional information
Checklist
black --fast homeassistant tests
)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest
.requirements_all.txt
.Updated by running
python3 -m script.gen_requirements_all
..coveragerc
.The integration reached or maintains the following Integration Quality Scale:
To help with the load of incoming pull requests: