Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Blebox light scenes #75106

Merged
merged 5 commits into from
Jul 14, 2022
Merged

Fix Blebox light scenes #75106

merged 5 commits into from
Jul 14, 2022

Conversation

riokuu
Copy link
Contributor

@riokuu riokuu commented Jul 13, 2022 •
edited
Loading

Proposed change

User using scenes experienced that device is not responding at action.
This is caused because code wasn't expecting effect in pair with other
kwargs in async_turn_on method.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
  • Untested files have been added to .coveragerc.

The integration reached or maintains the following Integration Quality Scale:

  • No score or internal
  • 🥈 Silver
  • 🥇 Gold
  • 🏆 Platinum

To help with the load of incoming pull requests:

@probot-home-assistant
Copy link

Hey there @bbx-a, mind taking a look at this pull request as it has been labeled with an integration (blebox) you are listed as a code owner for? Thanks!
(message by CodeOwnersMention)

@frenck frenck added the smash Indicator this PR is close to finish for merging or closing label Jul 13, 2022
@MartinHjelmare MartinHjelmare changed the title Blebox light scenes entity bugfix. Fix Blebox light scenes Jul 13, 2022
MartinHjelmare
MartinHjelmare reviewed Jul 13, 2022
View reviewed changes
Copy link
Member

@MartinHjelmare MartinHjelmare left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please also add a test for calling the light turn on service with an effect and another parameter.

homeassistant/components/blebox/light.py Show resolved Hide resolved
@frenck frenck removed the smash Indicator this PR is close to finish for merging or closing label Jul 13, 2022
@riokuu riokuu requested a review from MartinHjelmare July 13, 2022 11:46
@riokuu riokuu requested a review from MartinHjelmare July 14, 2022 07:11
MartinHjelmare
MartinHjelmare approved these changes Jul 14, 2022
View reviewed changes
Copy link
Member

@MartinHjelmare MartinHjelmare left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@MartinHjelmare
Copy link
Member

I'll tag this and #74298 for the next patch release.

@MartinHjelmare MartinHjelmare added this to the 2022.7.5 milestone Jul 14, 2022
@MartinHjelmare MartinHjelmare merged commit 169264d into home-assistant:dev Jul 14, 2022
balloob pushed a commit that referenced this pull request Jul 15, 2022
@riokuu @balloob
Fix Blebox light scenes (#75106)
b5e2404 
* Bug fix for light platform, when async_turn_on recieves multiple keys.

* Changes according to @MartinHjelmare suggestion.

* Moved effect set call in BleBoxLightEntity.async_turn_on method.

* Added tests for effect in light platform. Added ValueError raise if effect not in effect list.

* Removed duplicated line from test as @MartinHjelmare suggested.
@balloob balloob mentioned this pull request Jul 15, 2022
Merged
@github-actions github-actions bot locked and limited conversation to collaborators Jul 16, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@MartinHjelmare MartinHjelmare MartinHjelmare approved these changes

Assignees
No one assigned
Labels
bugfix by-code-owner cherry-picked cla-signed integration: blebox small-pr PRs with less than 30 lines.
Projects
None yet
Milestone
2022.7.5
Development

Successfully merging this pull request may close these issues.
5 participants
@riokuu @MartinHjelmare @frenck @balloob @homeassistant