Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bump deCONZ dependency to fix #74791 #74804

Merged
merged 1 commit into from
Jul 9, 2022
Merged

Bump deCONZ dependency to fix #74791 #74804

merged 1 commit into from
Jul 9, 2022

Conversation

Kane610
Copy link
Member

@Kane610 Kane610 commented Jul 9, 2022

Breaking change

Proposed change

If Starkvind is off when loading deCONZ integration the Airquality sensor state would be unknown.
Kane610/deconz@v97...v98

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
  • Untested files have been added to .coveragerc.

The integration reached or maintains the following Integration Quality Scale:

  • No score or internal
  • 🥈 Silver
  • 🥇 Gold
  • 🏆 Platinum

To help with the load of incoming pull requests:

@Kane610 Kane610 added this to the 2022.7.3 milestone Jul 9, 2022
frenck
frenck approved these changes Jul 9, 2022
View reviewed changes
Copy link
Member

@frenck frenck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @Kane610 👍

@Kane610
Copy link
Member Author

Kane610 commented Jul 9, 2022

Thanks @frenck 🎉

@frenck frenck merged commit 63582c3 into home-assistant:dev Jul 9, 2022
@Kane610 Kane610 deleted the deconz-bump_pydeconz_to_v98 branch July 10, 2022 06:50
@Kane610
Copy link
Member Author

Kane610 commented Jul 10, 2022

Thank you @frenck 🎉

balloob pushed a commit that referenced this pull request Jul 10, 2022
@Kane610 @balloob
Bump deCONZ dependency to fix #74791 (#74804)
07f4efc
@balloob balloob mentioned this pull request Jul 10, 2022
Merged
@github-actions github-actions bot locked and limited conversation to collaborators Jul 11, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@frenck frenck frenck approved these changes

Assignees
No one assigned
Labels
bugfix by-code-owner cherry-picked cla-signed dependency-bump integration: deconz small-pr PRs with less than 30 lines.
Projects
None yet
Milestone
2022.7.3
Development

Successfully merging this pull request may close these issues.

deCONZ integration unable to setup when IKEA Starkvind is turned off
4 participants
@Kane610 @frenck @balloob @homeassistant