Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP: Mqtt discovery updates rework #67912

Closed
wants to merge 2 commits into from

Conversation

jbouwh
Copy link
Contributor

@jbouwh jbouwh commented Mar 9, 2022

Proposed change

Code for handling MQTT discovery updates for platforms without entities was specialized for notify. tag and device_automation. This PR moves the discovery logic and device updates to a centralized place.

For notify the discovery topic is now reset when the device is removed to avoid rediscovery after a restart.
This was already implemented for the tag platform.

DONE: notfify and tag
TODO: device_automation

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
  • Untested files have been added to .coveragerc.

The integration reached or maintains the following Integration Quality Scale:

  • No score or internal
  • 🥈 Silver
  • 🥇 Gold
  • 🏆 Platinum

To help with the load of incoming pull requests:

@probot-home-assistant
Copy link

Hey there @emontnemery, mind taking a look at this pull request as it has been labeled with an integration (mqtt) you are listed as a code owner for? Thanks!
(message by CodeOwnersMention)

@jbouwh jbouwh marked this pull request as draft March 9, 2022 15:06
@jbouwh jbouwh changed the title Mqtt notify discovery updates rework WIP: Mqtt notify discovery updates rework Mar 9, 2022
@jbouwh jbouwh force-pushed the mqtt-device-update-rework branch 2 times, most recently from 4b9768f to afd7a37 Compare March 9, 2022 15:11
@jbouwh jbouwh mentioned this pull request Mar 9, 2022
22 tasks
@jbouwh jbouwh changed the title WIP: Mqtt notify discovery updates rework WIP: Mqtt discovery updates rework Mar 9, 2022
@jbouwh jbouwh force-pushed the mqtt-device-update-rework branch from 75a8e00 to 0952f3f Compare March 9, 2022 19:18
jbouwh added a commit to jbouwh/core that referenced this pull request Mar 12, 2022
@jbouwh jbouwh mentioned this pull request Mar 12, 2022
22 tasks
@jbouwh jbouwh mentioned this pull request Mar 12, 2022
22 tasks
@jbouwh
Copy link
Contributor Author

jbouwh commented Mar 12, 2022

This PR is superseded by #67966.

@jbouwh jbouwh closed this Mar 12, 2022
@github-actions github-actions bot locked and limited conversation to collaborators Mar 13, 2022
@jbouwh jbouwh deleted the mqtt-device-update-rework branch April 21, 2023 07:46
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants