-
-
Notifications
You must be signed in to change notification settings - Fork 31.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Migrate binary sensor device classes to StrEnum #60651
Conversation
Hey there @home-assistant/core, mind taking a look at this pull request as it has been labeled with an integration ( |
Hey there @eavanvalkenburg, mind taking a look at this pull request as it has been labeled with an integration ( |
Hey there @scop, mind taking a look at this pull request as it has been labeled with an integration ( |
@@ -29,3 +33,5 @@ async def async_setup_entry( | |||
|
|||
class UpCloudBinarySensor(UpCloudServerEntity, BinarySensorEntity): | |||
"""Representation of an UpCloud server sensor.""" | |||
|
|||
_attr_device_class = BinarySensorDeviceClass.POWER |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't know this integration, is this correct?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Previously it used a hard coded string in its parent class to "power" for all iets platforms...
So this makes it specific on this platform to fix that (and make mypy happy as it now has catches this bug)
Breaking change
This PR deprecates the use of the
DEVICE_CLASS_*
constants andDEVICE_CLASSES
constant forbinary_sensor
entities. Use theBinarySensorDeviceClass
enum instead.Proposed change
Replaces the device class constants of the binary sensor platform with a StrEnum.
The old CONST is currently still accepted and working (backward compatible). This gives core and custom integration time to adjust.
At this point, I've not set a deprecation period as it is hard to indicate how long this would take.
Type of change
Additional information
Checklist
black --fast homeassistant tests
)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest
.requirements_all.txt
.Updated by running
python3 -m script.gen_requirements_all
..coveragerc
.The integration reached or maintains the following Integration Quality Scale:
To help with the load of incoming pull requests: