Fix CORS #59360
Merged
Fix CORS #59360
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
probot-home-assistant
bot
added
bugfix
core
has-tests
integration: http
small-pr
|
Hey there @home-assistant/core, mind taking a look at this pull request as it has been labeled with an integration ( |
balloob
reviewed
Nov 8, 2021
| if not self.cors_allowed: | ||
| return | ||
|
|
||
| add_cors = app["allow_cors"] if self.cors_allowed else app["add_cors"] |
There was a problem hiding this comment.
Can we make these keys a bit more descriptive
allow_cors->allow_all_corsadd_cors->allow_configured_cors
balloob
approved these changes
Nov 8, 2021
balloob
approved these changes
Nov 8, 2021
balloob
reviewed
Nov 9, 2021
| if origins: | ||
| app["allow_configured_cors"] = _allow_cors | ||
| else: | ||
| app["allow_configured_cors"] = lambda _: None |
There was a problem hiding this comment.
Can you add a test to validate this behavior now works as expected
There was a problem hiding this comment.
sorry, saw the comment to late :/
balloob
approved these changes
Nov 9, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed change
Since we start the web server before Home Assistant is done setting up, CORS was only setup on the routes that where registered before the app started, as we would run over the registered routes at startup.
I now moved this to the place the route is registered, so whenever a route gets registered it is also allowed for CORS.
Type of change
Additional information
Checklist
black --fast homeassistant tests)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest.requirements_all.txt.Updated by running
python3 -m script.gen_requirements_all..coveragerc.The integration reached or maintains the following Integration Quality Scale:
To help with the load of incoming pull requests: