Update version for smart-meter-texas to 0.4.7 #54493

meyerrj · 2021-08-11T18:41:00Z

Proposed change

Update library version to fix a broken API call.
Changelog: grahamwetzler/smart-meter-texas@v0.4.0...v0.4.7

Potential fix for #40348

Type of change

[ x] Dependency upgrade
[ x] Bugfix (non-breaking change which fixes an issue)
New integration (thank you!)
New feature (which adds functionality to an existing integration)
Breaking change (fix/feature causing existing functionality to break)
Code quality improvements to existing code or addition of tests

Additional information

This PR fixes or closes issue: fixes Smart Meter Texas Integration Failed to Connect #40348
This PR is related to issue: Smart Meter Texas Integration Failed to Connect #40348

Checklist

The code change is tested and works locally.
Local tests pass. Your PR cannot be merged unless tests pass
There is no commented out code in this PR.
I have followed the development checklist
The code has been formatted using Black (black --fast homeassistant tests)
Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

Documentation added/updated for www.home-assistant.io

If the code communicates with devices, web services, or third-party tools:

The manifest file has all fields filled out correctly.
Updated and included derived files by running: python3 -m script.hassfest.
New or updated dependencies have been added to requirements_all.txt.
Updated by running python3 -m script.gen_requirements_all.
Untested files have been added to .coveragerc.

The integration reached or maintains the following Integration Quality Scale:

No score or internal
🥈 Silver
🥇 Gold
🏆 Platinum

To help with the load of incoming pull requests:

I have reviewed two other open pull requests in this repository.

Potential fix for home-assistant#40348

homeassistant · 2021-08-11T18:41:03Z

Hi @meyerrj,

It seems you haven't yet signed a CLA. Please do so here.

Once you do that we will be able to review and accept this pull request.

Thanks!

probot-home-assistant · 2021-08-11T18:41:11Z

Hey there @grahamwetzler, mind taking a look at this pull request as it has been labeled with an integration (smart_meter_texas) you are listed as a code owner for? Thanks!
_{^{(message by CodeOwnersMention)}}

grahamwetzler · 2021-08-11T18:53:36Z

Thanks again @meyerrj, I just deployed v0.4.4 https://pypi.org/manage/project/smart-meter-texas/release/0.4.4/

meyerrj · 2021-08-11T18:56:15Z

No problem @grahamwetzler! Thanks for all your work on this project!

bdraco · 2021-08-11T21:46:39Z

You'll need to regenerate requirements

python3 -m script.gen_requirements_all

bdraco

Please see above

bdraco · 2021-08-12T03:16:37Z

Seeing this when testing

2021-08-12 03:15:59 ERROR (MainThread) [homeassistant.components.smart_meter_texas.config_flow] Cannot connect
Traceback (most recent call last):
  File "/usr/local/lib/python3.8/site-packages/aiohttp/connector.py", line 969, in _wrap_create_connection
    return await self._loop.create_connection(*args, **kwargs)  # type: ignore  # noqa
  File "/usr/local/lib/python3.8/asyncio/base_events.py", line 1050, in create_connection
    transport, protocol = await self._create_connection_transport(
  File "/usr/local/lib/python3.8/asyncio/base_events.py", line 1080, in _create_connection_transport
    await waiter
  File "/usr/local/lib/python3.8/asyncio/sslproto.py", line 529, in data_received
    ssldata, appdata = self._sslpipe.feed_ssldata(data)
  File "/usr/local/lib/python3.8/asyncio/sslproto.py", line 189, in feed_ssldata
    self._sslobj.do_handshake()
  File "/usr/local/lib/python3.8/ssl.py", line 944, in do_handshake
    self._sslobj.do_handshake()
ssl.SSLCertVerificationError: [SSL: CERTIFICATE_VERIFY_FAILED] certificate verify failed: unable to get local issuer certificate (_ssl.c:1125)

The above exception was the direct cause of the following exception:

Traceback (most recent call last):
  File "/usr/src/homeassistant/homeassistant/components/smart_meter_texas/config_flow.py", line 37, in validate_input
    await client.authenticate()
  File "/usr/local/lib/python3.8/site-packages/smart_meter_texas/__init__.py", line 166, in authenticate
    await self._init_websession()
  File "/usr/local/lib/python3.8/site-packages/smart_meter_texas/__init__.py", line 126, in _init_websession
    await self.websession.get(BASE_URL, headers=self._agent_headers())
  File "/usr/local/lib/python3.8/site-packages/aiohttp/client.py", line 520, in _request
    conn = await self._connector.connect(
  File "/usr/local/lib/python3.8/site-packages/aiohttp/connector.py", line 535, in connect
    proto = await self._create_connection(req, traces, timeout)
  File "/usr/local/lib/python3.8/site-packages/aiohttp/connector.py", line 892, in _create_connection
    _, proto = await self._create_direct_connection(req, traces, timeout)
  File "/usr/local/lib/python3.8/site-packages/aiohttp/connector.py", line 1051, in _create_direct_connection
    raise last_exc
  File "/usr/local/lib/python3.8/site-packages/aiohttp/connector.py", line 1020, in _create_direct_connection
    transp, proto = await self._wrap_create_connection(
  File "/usr/local/lib/python3.8/site-packages/aiohttp/connector.py", line 971, in _wrap_create_connection
    raise ClientConnectorCertificateError(req.connection_key, exc) from exc
aiohttp.client_exceptions.ClientConnectorCertificateError: Cannot connect to host smartmetertexas.com:443 ssl:True [SSLCertVerificationError: (1, '[SSL: CERTIFICATE_VERIFY_FAILED] certificate verify failed: unable to get local issuer certificate (_ssl.c:1125)')]

The above exception was the direct cause of the following exception:

Traceback (most recent call last):
  File "/usr/src/homeassistant/homeassistant/components/smart_meter_texas/config_flow.py", line 58, in async_step_user
    info = await validate_input(self.hass, user_input)
  File "/usr/src/homeassistant/homeassistant/components/smart_meter_texas/config_flow.py", line 39, in validate_input
    raise CannotConnect from error
homeassistant.components.smart_meter_texas.config_flow.CannotConnect

meyerrj · 2021-08-12T04:51:06Z

Could the exception possibly be an issue with the SSL library on the client?

meyerrj · 2021-08-12T05:40:45Z

I found these issues:
https://bugs.python.org/issue36137
https://bugs.python.org/issue36011

It appears that Python's default SSL library on various platforms may be missing some CAs needed to verify some websites, It has some interesting behavior when working through Docker on Windows too.

meyerrj · 2021-08-13T21:12:36Z

@bdraco Just wanted to follow up. Can you confirm that the SSL error you received wasn't an issue with your Python/SSL environment?

bdraco · 2021-08-13T21:20:41Z

I tried production and dev. Error both places

meyerrj · 2021-08-13T21:30:06Z

@bdraco Everything I can find on the error points to an issue with the local certificates being out of date or incomplete...

Short of making the library ignore SSL validation (which isn't recommended), I think this issue needs to be resolved in the environment somehow.

@grahamwetzler Another thought may be to import the certifi module and use that ssl context... aio-libs/aiohttp#955 (comment) Thoughts?

meyerrj · 2021-08-13T23:34:26Z

I found an issue in the site's certificate chain using ssllabs.com to test the site...

I'm now able to reproduce the error with the library itself, so back to testing for a solution.

bdraco · 2021-08-13T23:45:11Z

Is it a new intermediate certificate that isn't in the version of certifi that home assistant uses?

Does upgrading to certifi 2021.5.30 include it?

meyerrj · 2021-08-14T02:37:30Z

So, this definitely appears to get even more troublesome than I had anticipated...

The library works with Python on Windows for me just fine, but not Linux. Updating certifi did not help, either.

The only way I can currently get it to work on Linux is by setting the sslcontext.verify_mode to none, or by passing in the certificate chain file when working against smartmetertexas.com.

Also, the SSL certificate chain is correct for the www.smartmetertexas.com domain, but entirely different for smartmetertexas.com. The ssllabs test returns different results too. 🤦‍♂️

bdraco · 2021-08-24T16:33:36Z

Its setting up now, but the meter is showing unavailable

meyerrj · 2021-08-24T16:35:50Z

I noticed that the smart meter website can have some latency with getting your meter and meter stats on first setup, and sometimes it takes a while before it actually returns result for your "current" usage. Sometimes I'm only able to query the previous day's information until late in the day.

bdraco · 2021-08-24T16:36:44Z

I started the CI. I'll recheck it in 30m and see if it becomes available

bdraco · 2021-08-24T16:42:48Z

It's working. Just took 6 minutes to do the first poll

meyerrj · 2021-08-24T16:45:10Z

Hooray! Thanks for all the help in getting this resolved! I'm excited to get this working on my HA. 😁

bdraco

Should be good to go if the CI passes

bdraco · 2021-08-24T16:45:41Z

If you want to add support for the energy integration in a future PR:

https://developers.home-assistant.io/docs/core/entity/sensor#long-term-statistics

bdraco · 2021-08-24T17:11:14Z

Looks like there are some formatting and a pylint issue to address

meyerrj · 2021-08-24T17:23:36Z

GitHub's web editor is not well suited for Python. 🤦‍♂️

homeassistant/components/smart_meter_texas/__init__.py

Co-authored-by: J. Nick Koston <[email protected]>

homeassistant/components/smart_meter_texas/__init__.py

Co-authored-by: J. Nick Koston <[email protected]>

bdraco · 2021-08-24T17:31:23Z

Checked manually, should be good now.

Retesting...

bdraco · 2021-08-24T17:32:15Z

testing looks good 👍

meyerrj · 2021-08-24T17:33:07Z

Sorry for the trouble with this. My python is admittedly a little rusty after roughly a decade.
This has certainly been a fun deep dive to relearn some lessons.

bdraco · 2021-08-24T19:10:18Z

CI failure is unrelated and being worked on in #55169

Update version for smart-meter-texas to 0.4.4

386bc1d

Potential fix for home-assistant#40348

homeassistant added the cla-needed label Aug 11, 2021

probot-home-assistant bot added dependency-bump bugfix dependency integration: smart_meter_texas small-pr PRs with less than 30 lines. labels Aug 11, 2021

homeassistant added cla-signed and removed cla-needed labels Aug 11, 2021

bdraco requested changes Aug 11, 2021

View reviewed changes

Fix requirements for smart_meter_texas

ebf6d80

meyerrj requested a review from bdraco August 12, 2021 01:34

grahamwetzler mentioned this pull request Aug 12, 2021

Failing to connect home-assistant/home-assistant.io#18895

Closed

Merge branch 'home-assistant:dev' into dev

f394271

bdraco approved these changes Aug 24, 2021

View reviewed changes

bdraco added the smash Indicator this PR is close to finish for merging or closing label Aug 24, 2021

Updates using Black

9e184dd

bdraco reviewed Aug 24, 2021

View reviewed changes

homeassistant/components/smart_meter_texas/__init__.py Outdated Show resolved Hide resolved

bdraco reviewed Aug 24, 2021

View reviewed changes

homeassistant/components/smart_meter_texas/__init__.py Outdated Show resolved Hide resolved

bdraco reviewed Aug 24, 2021

View reviewed changes

homeassistant/components/smart_meter_texas/__init__.py Outdated Show resolved Hide resolved

bdraco reviewed Aug 24, 2021

View reviewed changes

homeassistant/components/smart_meter_texas/__init__.py Show resolved Hide resolved

meyerrj and others added 4 commits August 24, 2021 12:26

Update homeassistant/components/smart_meter_texas/__init__.py

6971244

Co-authored-by: J. Nick Koston <[email protected]>

Update homeassistant/components/smart_meter_texas/__init__.py

4321c3a

Co-authored-by: J. Nick Koston <[email protected]>

Update homeassistant/components/smart_meter_texas/__init__.py

f61d701

Co-authored-by: J. Nick Koston <[email protected]>

Update homeassistant/components/smart_meter_texas/__init__.py

f178a24

Co-authored-by: J. Nick Koston <[email protected]>

bdraco reviewed Aug 24, 2021

View reviewed changes

homeassistant/components/smart_meter_texas/__init__.py Show resolved Hide resolved

Update homeassistant/components/smart_meter_texas/__init__.py

9cf069c

Co-authored-by: J. Nick Koston <[email protected]>

bdraco approved these changes Aug 24, 2021

View reviewed changes

bdraco merged commit 2932a3d into home-assistant:dev Aug 24, 2021

github-actions bot locked and limited conversation to collaborators Aug 25, 2021

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Update version for smart-meter-texas to 0.4.7 #54493

Update version for smart-meter-texas to 0.4.7 #54493

meyerrj commented Aug 11, 2021 •

edited by bdraco

Loading

homeassistant commented Aug 11, 2021

probot-home-assistant bot commented Aug 11, 2021

grahamwetzler commented Aug 11, 2021

meyerrj commented Aug 11, 2021

bdraco commented Aug 11, 2021

bdraco left a comment

bdraco commented Aug 12, 2021

meyerrj commented Aug 12, 2021

meyerrj commented Aug 12, 2021

meyerrj commented Aug 13, 2021

bdraco commented Aug 13, 2021

meyerrj commented Aug 13, 2021

meyerrj commented Aug 13, 2021

bdraco commented Aug 13, 2021

meyerrj commented Aug 14, 2021

bdraco commented Aug 24, 2021

meyerrj commented Aug 24, 2021

bdraco commented Aug 24, 2021

bdraco commented Aug 24, 2021 •

edited

Loading

meyerrj commented Aug 24, 2021

bdraco left a comment

bdraco commented Aug 24, 2021

bdraco commented Aug 24, 2021

meyerrj commented Aug 24, 2021

bdraco commented Aug 24, 2021

bdraco commented Aug 24, 2021

meyerrj commented Aug 24, 2021

bdraco commented Aug 24, 2021

Update version for smart-meter-texas to 0.4.7 #54493

Update version for smart-meter-texas to 0.4.7 #54493

Conversation

meyerrj commented Aug 11, 2021 • edited by bdraco Loading

Proposed change

Type of change

Additional information

Checklist

homeassistant commented Aug 11, 2021

probot-home-assistant bot commented Aug 11, 2021

grahamwetzler commented Aug 11, 2021

meyerrj commented Aug 11, 2021

bdraco commented Aug 11, 2021

bdraco left a comment

Choose a reason for hiding this comment

bdraco commented Aug 12, 2021

meyerrj commented Aug 12, 2021

meyerrj commented Aug 12, 2021

meyerrj commented Aug 13, 2021

bdraco commented Aug 13, 2021

meyerrj commented Aug 13, 2021

meyerrj commented Aug 13, 2021

bdraco commented Aug 13, 2021

meyerrj commented Aug 14, 2021

bdraco commented Aug 24, 2021

meyerrj commented Aug 24, 2021

bdraco commented Aug 24, 2021

bdraco commented Aug 24, 2021 • edited Loading

meyerrj commented Aug 24, 2021

bdraco left a comment

Choose a reason for hiding this comment

bdraco commented Aug 24, 2021

bdraco commented Aug 24, 2021

meyerrj commented Aug 24, 2021

bdraco commented Aug 24, 2021

bdraco commented Aug 24, 2021

meyerrj commented Aug 24, 2021

bdraco commented Aug 24, 2021

meyerrj commented Aug 11, 2021 •

edited by bdraco

Loading

bdraco commented Aug 24, 2021 •

edited

Loading