Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ESPHome rework EsphomeEnumMapper for safe enum mappings #51975

Merged
merged 2 commits into from
Jun 22, 2021

Conversation

OttoWinter
Copy link
Member

@OttoWinter OttoWinter commented Jun 18, 2021

Proposed change

When the ESPHome client device has a higher API version (with new enum fields) than HA core, errors are thrown for unmappable enum types (esphome/aioesphomeapi#35 (comment))

This PR fixes that by allowing None values from esphome/aioesphomeapi#37 in the mapping conversion. It also refactors the EsphomeEnumMapper class (it's old design was before the days where global package imports were possible), because it would have been more difficult to change without a refactor.

Note: depends on esphome/aioesphomeapi#37 and dependency bump of aioesphomeapi Done

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • Untested files have been added to .coveragerc.

The integration reached or maintains the following Integration Quality Scale:

  • No score or internal
  • 🥈 Silver
  • 🥇 Gold
  • 🏆 Platinum

To help with the load of incoming pull requests:

@OttoWinter OttoWinter marked this pull request as ready for review June 18, 2021 15:02
@OttoWinter OttoWinter changed the title ESPHome rework EsphomeEnumMapper and support safe enum mappings ESPHome rework EsphomeEnumMapper for safe enum mappings Jun 18, 2021
@balloob balloob merged commit 03ec7b3 into home-assistant:dev Jun 22, 2021
@OttoWinter OttoWinter deleted the esphome-enum-safe-mapping branch June 22, 2021 05:27
@github-actions github-actions bot locked and limited conversation to collaborators Jun 23, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants