ESPHome rework EsphomeEnumMapper for safe enum mappings #51975
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed change
When the ESPHome client device has a higher API version (with new enum fields) than HA core, errors are thrown for unmappable enum types (esphome/aioesphomeapi#35 (comment))
This PR fixes that by allowing
None
values from esphome/aioesphomeapi#37 in the mapping conversion. It also refactors theEsphomeEnumMapper
class (it's old design was before the days where global package imports were possible), because it would have been more difficult to change without a refactor.Note: depends on esphome/aioesphomeapi#37 and dependency bump of aioesphomeapiDoneType of change
Additional information
Checklist
black --fast homeassistant tests
)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest
.requirements_all.txt
.Updated by running
python3 -m script.gen_requirements_all
..coveragerc
.The integration reached or maintains the following Integration Quality Scale:
To help with the load of incoming pull requests: