Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Provide unique IDs for Lutron Entities #51395

Merged
merged 2 commits into from
Aug 24, 2021
Merged

Conversation

cdheiser
Copy link
Contributor

@cdheiser cdheiser commented Jun 3, 2021

Breaking change

Proposed change

This change adds unique ids for all Lutron entities. This enables users to rename entities, assign rooms, and change the icons. Unique ids are pulled from the configuration in the main repeater, and are thus bound to that repeater.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • Untested files have been added to .coveragerc.

The integration reached or maintains the following Integration Quality Scale:

  • No score or internal
  • 🥈 Silver
  • 🥇 Gold
  • 🏆 Platinum

To help with the load of incoming pull requests:

…ead of accessing a protected member of the LutronEntity
@cdheiser cdheiser requested a review from balloob July 11, 2021 02:31
@cdheiser
Copy link
Contributor Author

@JonGilmore any ideas on moving this PR forward?

@JonGilmore
Copy link
Contributor

LGTM, sorry this fell off my radar to test

@frenck frenck added the smash Indicator this PR is close to finish for merging or closing label Aug 23, 2021
Copy link
Member

@frenck frenck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I share the concerns raised (unique ID not unique enough on an entity level), however, this is not a problem right now as shown in the responses by the author.

If in the far future this needs changing, migration can be put into place. So, I think for now this is fine 👍

Thanks @cdheiser 👍

@frenck frenck merged commit ede916f into home-assistant:dev Aug 24, 2021
@github-actions github-actions bot locked and limited conversation to collaborators Aug 25, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
cla-signed integration: lutron new-feature small-pr PRs with less than 30 lines. smash Indicator this PR is close to finish for merging or closing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants