Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add get_config_parameters websocket command to zwave_js #46463

Merged
merged 10 commits into from
Feb 22, 2021

Conversation

cgarwood
Copy link
Member

@cgarwood cgarwood commented Feb 12, 2021

Proposed change

Adds a get_config_parameters websocket command to the zwave_js integration. Will be used for the frontend config panel.

Will require a new release of the upstream zwave-js-server-python library.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • Untested files have been added to .coveragerc.

The integration reached or maintains the following Integration Quality Scale:

  • No score or internal
  • 🥈 Silver
  • 🥇 Gold
  • 🏆 Platinum

To help with the load of incoming pull requests:

@probot-home-assistant
Copy link

Hey there @home-assistant/z-wave, mind taking a look at this pull request as its been labeled with an integration (zwave_js) you are listed as a codeowner for? Thanks!
(message by CodeOwnersMention)

@raman325
Copy link
Contributor

aside from my comments, looks good! Just keep in mind that we can't set all configuration values, so we will need some handling for that when we add support for it. If nothing else it could be as simple as catching the exception that will get raised when calling async_set_value

@cgarwood
Copy link
Member Author

Marking as draft until upstream lib gets bumped

@cgarwood cgarwood marked this pull request as draft February 12, 2021 21:12
Copy link
Contributor

@raman325 raman325 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM once tests pass!

@cgarwood
Copy link
Member Author

Just waiting for a new release of the lib 🙂

@raman325 raman325 added the waiting-for-upstream We're waiting for a change upstream label Feb 16, 2021
@raman325 raman325 removed the waiting-for-upstream We're waiting for a change upstream label Feb 21, 2021
@raman325
Copy link
Contributor

this needs a rebase then it should hopefully be good to go

@raman325
Copy link
Contributor

should this be renamed get_config_parameters to match the service?

@raman325
Copy link
Contributor

I added a commit to #46673 to include a set_config_parameter WS API command

@raman325 raman325 changed the title Add get_configuration_values websocket command to zwave_js Add get_config_parameters websocket command to zwave_js Feb 22, 2021
@MartinHjelmare
Copy link
Member

There are unrelated commits.

@cgarwood
Copy link
Member Author

aaaah rebase failure

@cgarwood
Copy link
Member Author

OK fixed the rebase disaster

@raman325
Copy link
Contributor

I think we can mark this Ready for review?

Copy link
Contributor

@raman325 raman325 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

re-approving since there were some changes, but it looks good!

@cgarwood cgarwood marked this pull request as ready for review February 22, 2021 21:22
Copy link
Member

@MartinHjelmare MartinHjelmare left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@raman325 raman325 merged commit 04e07d8 into home-assistant:dev Feb 22, 2021
@cgarwood cgarwood deleted the zwjs_get_config_ws branch February 22, 2021 22:59
@github-actions github-actions bot locked and limited conversation to collaborators Feb 23, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants