-
-
Notifications
You must be signed in to change notification settings - Fork 32.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add get_config_parameters websocket command to zwave_js #46463
Conversation
Hey there @home-assistant/z-wave, mind taking a look at this pull request as its been labeled with an integration ( |
aside from my comments, looks good! Just keep in mind that we can't set all configuration values, so we will need some handling for that when we add support for it. If nothing else it could be as simple as catching the exception that will get raised when calling |
Marking as draft until upstream lib gets bumped |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM once tests pass!
Just waiting for a new release of the lib 🙂 |
e904be8
to
5aac77c
Compare
this needs a rebase then it should hopefully be good to go |
should this be renamed |
I added a commit to #46673 to include a |
5aac77c
to
a561bde
Compare
There are unrelated commits. |
aaaah rebase failure |
b16dd64
to
a3e7619
Compare
OK fixed the rebase disaster |
I think we can mark this Ready for review? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
re-approving since there were some changes, but it looks good!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good!
Proposed change
Adds a get_config_parameters websocket command to the zwave_js integration. Will be used for the frontend config panel.
Will require a new release of the upstream zwave-js-server-python library.Type of change
Additional information
Checklist
black --fast homeassistant tests
)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest
.requirements_all.txt
.Updated by running
python3 -m script.gen_requirements_all
..coveragerc
.The integration reached or maintains the following Integration Quality Scale:
To help with the load of incoming pull requests: