Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Vacation Mode on Alarm Panels #45980

Merged
merged 76 commits into from
Jul 1, 2021
Merged

Vacation Mode on Alarm Panels #45980

merged 76 commits into from
Jul 1, 2021

Conversation

posixx
Copy link
Contributor

@posixx posixx commented Feb 4, 2021

Proposed change

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • Untested files have been added to .coveragerc.

The integration reached or maintains the following Integration Quality Scale:

  • No score or internal
  • 🥈 Silver
  • 🥇 Gold
  • 🏆 Platinum

To help with the load of incoming pull requests:

Proof of working vacation mode:

image

image

@posixx
Copy link
Contributor Author

posixx commented Apr 6, 2021

is it possible someon takes over ownership of this PR? I am committing things to solve but have no idea what i am doing... I think i make things worse..

@posixx posixx requested a review from MartinHjelmare April 7, 2021 10:54
@github-actions
Copy link

github-actions bot commented May 7, 2021

There hasn't been any activity on this pull request recently. This pull request has been automatically marked as stale because of that and will be closed if no further activity occurs within 7 days.
Thank you for your contributions.

@github-actions github-actions bot added the stale label May 7, 2021
@posixx
Copy link
Contributor Author

posixx commented May 7, 2021

When is this proposed change merged into the core? It's ready about one month now..

@github-actions github-actions bot removed the stale label May 7, 2021
@github-actions
Copy link

github-actions bot commented Jun 6, 2021

There hasn't been any activity on this pull request recently. This pull request has been automatically marked as stale because of that and will be closed if no further activity occurs within 7 days.
Thank you for your contributions.

Copy link
Contributor

@emontnemery emontnemery left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks a lot @posixx and @KJonline 👍

@emontnemery emontnemery dismissed MartinHjelmare’s stale review July 1, 2021 14:02

The comments have been addressed

@frenck frenck merged commit 3125319 into home-assistant:dev Jul 1, 2021
@github-actions github-actions bot locked and limited conversation to collaborators Jul 2, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants