-
-
Notifications
You must be signed in to change notification settings - Fork 32.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Vacation Mode on Alarm Panels #45980
Conversation
This reverts commit 419e2da.
Co-authored-by: Nathan Tilley <[email protected]>
Co-authored-by: Nathan Tilley <[email protected]>
This reverts commit bb238a7.
Alarm Vacation Mode - Update test configuration.
tests/testing_config/custom_components/test/alarm_control_panel.py
Outdated
Show resolved
Hide resolved
…l.py Co-authored-by: Martin Hjelmare <[email protected]>
is it possible someon takes over ownership of this PR? I am committing things to solve but have no idea what i am doing... I think i make things worse.. |
Update from fork
Fix tests for vacation mode
Remove alarm helper
There hasn't been any activity on this pull request recently. This pull request has been automatically marked as stale because of that and will be closed if no further activity occurs within 7 days. |
When is this proposed change merged into the core? It's ready about one month now.. |
There hasn't been any activity on this pull request recently. This pull request has been automatically marked as stale because of that and will be closed if no further activity occurs within 7 days. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The comments have been addressed
Co-authored-by: Franck Nijhof <[email protected]>
Proposed change
Type of change
Additional information
Checklist
black --fast homeassistant tests
)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest
.requirements_all.txt
.Updated by running
python3 -m script.gen_requirements_all
..coveragerc
.The integration reached or maintains the following Integration Quality Scale:
To help with the load of incoming pull requests:
Proof of working vacation mode: