Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix volume calculation of Onkyo MediaPlayer #42236

Merged
merged 2 commits into from
Nov 9, 2020

Conversation

ZzetT
Copy link
Contributor

@ZzetT ZzetT commented Oct 22, 2020

Proposed change

If the max_volume is configured for the Onkyo integration and the user sets a new volume in the media player, the volume is correctly transmitted to the receiver, but when update() of that player is called, the volume (returned by volume_level()) is calculated wrongly and thus the slider in the media player jumps to another position. In fact, the formula misses some parentheses.
I wrote the details down in: #41655 (comment)

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Example entry for configuration.yaml:

# Example configuration.yaml
media_player:
  - platform: onkyo
    host: 192.168.178.30
    name: Onkyo Receiver
    max_volume: 33

Additional information

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
    IMHO the integration doesn't have any tests
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • Untested files have been added to .coveragerc.

The integration reached or maintains the following Integration Quality Scale:

  • No score or internal
  • 🥈 Silver
  • 🥇 Gold
  • 🏆 Platinum

To help with the load of incoming pull requests:

Copy link
Member

@MartinHjelmare MartinHjelmare left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@MartinHjelmare MartinHjelmare merged commit d8f2d04 into home-assistant:dev Nov 9, 2020
@MartinHjelmare MartinHjelmare modified the milestone: 0.117.6 Nov 9, 2020
@arturpragacz arturpragacz mentioned this pull request Jun 19, 2024
20 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Onkyo media_player volume_level issue when max_volume set
3 participants