-
-
Notifications
You must be signed in to change notification settings - Fork 32.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adjust dts warning messages in stream #41467
Adjust dts warning messages in stream #41467
Conversation
@hunterjm You were right about still needing this monotonicity check. It looks like the demuxer does get rid of strictly out of order packets but still allows packets with equal dts through. |
6a328bc
to
9f47c5e
Compare
1856daf
to
bab5fdb
Compare
Just removed the out of packet warning. It's not really necessary anymore. |
* Adjust dts warning messages * Wait for second packet with overflow dts condition * Rename dts gap watch variable * Remove out of order packet warning
Sorry in front for a possible total stupid question. I am also getting the "Timestamp overflow ressetting stream" error constantly. I am totally new with this so please bear with me :) |
@Johndolk - it should be a part of the 0.117 release. |
Ohh i see! So these things are stuff that are supposed to be added in a new update - I am learning new things about this every day but for me it is a bit of a jungle! Thank you so much for replying so swiftly |
Proposed change
We added some warning messages when encountering out of order packets in #39844 . It seems like the pyav rtsp demuxer automatically drops out of order packets, but it allows packets with the same DTS through.
For out of order packets, this PR skips printing the warning if consecutive packets with the same DTS are encountered. With this change, we do not expect the out of order packet warning to ever be printed as the demuxer should drop the strictly out of order packets, and this warning should only print for these strictly out of order packets.
This PR also adjusts the overflow warning to include the last dts value for help with troubleshooting.
Type of change
Example entry for
configuration.yaml
:# Example configuration.yaml
Additional information
Checklist
black --fast homeassistant tests
)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest
.requirements_all.txt
.Updated by running
python3 -m script.gen_requirements_all
..coveragerc
.The integration reached or maintains the following Integration Quality Scale:
To help with the load of incoming pull requests: