Create MQTTMatcher once per subscription instead of each message

[bdraco]

Proposed change

Create MQTTMatcher once per subscription instead of each message

This should improve the performance for cases like #40292

Type of change

• Dependency upgrade
• Bugfix (non-breaking change which fixes an issue)
• New integration (thank you!)
• New feature (which adds functionality to an existing integration)
• Breaking change (fix/feature causing existing functionality to break)
• Code quality improvements to existing code or addition of tests

Example entry for configuration.yaml:

# Example configuration.yaml

Additional information

• This PR fixes or closes issue: fixes Higher CPU continues in 0.118 #40292
• This PR is related to issue:
• Link to documentation pull request:

Checklist

• The code change is tested and works locally.
• Local tests pass. Your PR cannot be merged unless tests pass
• There is no commented out code in this PR.
• I have followed the development checklist
• The code has been formatted using Black (black --fast homeassistant tests)
• Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

• Documentation added/updated for www.home-assistant.io

If the code communicates with devices, web services, or third-party tools:

• The manifest file has all fields filled out correctly.
  Updated and included derived files by running: python3 -m script.hassfest.
• New or updated dependencies have been added to requirements_all.txt.
  Updated by running python3 -m script.gen_requirements_all.
• Untested files have been added to .coveragerc.

The integration reached or maintains the following Integration Quality Scale:

• No score or internal
• 🥈 Silver
• 🥇 Gold
• 🏆 Platinum

To help with the load of incoming pull requests:

• I have reviewed two other open pull requests in this repository.

[bdraco]

I don't have access to my MQTT test setup at the moment so this shouldn't merge until someone can give it a try.

[emontnemery]

@bdraco i can give it a try, anything special you want me to test?

[bdraco]

@bdraco i can give it a try, anything special you want me to test?

Thank you. 👍 👍 👍 There shouldn't be anything special. Hopefully it should be strait-forward and continuing matching what you would expect to match before the change.

[balloob]

Confirmed working by @emontnemery

[Spirituss]

@bdraco @balloob
Guys, will this PR fix as well this issue?
#40728

[emontnemery]

@Spirituss Possibly because it speed up MQTT message handling, however something is very broken in the way zigbee2mqtt sends messages or there's a problem in your setup.