Fix double encoding issue in google_translate TTS #38429
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
probot-home-assistant
bot
added
bugfix
integration: google_translate
small-pr
MartinHjelmare
approved these changes
Jul 31, 2020
balloob
reviewed
Aug 1, 2020
| @@ -129,7 +128,7 @@ async def async_get_tts_audio(self, message, language, options=None): | |||
| url_param = { | |||
| "ie": "UTF-8", | |||
| "tl": language, | |||
| "q": yarl.URL(part).raw_path, | |||
| "q": part, | |||
There was a problem hiding this comment.
I'm surprised this was ever necessary, given that aiohttp should do this for all data passed to params
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed change
With the release of yarl 1.5.0, an URL encoding issue has been fixed:
aio-libs/yarl#426
Which caused our
google_translateintegration to break.Right now, the message is double encoded (once by yarl, next by the request).
Variable stack from debugging the integration:
We really don't need yarl at this point, since request handles it. This PR removes the use of yarl from this integration.
Additionally,
yarlis pinned as a core dependency in #38428Type of change
Example entry for
configuration.yaml:# Example configuration.yamlAdditional information
Checklist
black --fast homeassistant tests)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest.requirements_all.txt.Updated by running
python3 -m script.gen_requirements_all..coveragerc.The integration reached or maintains the following Integration Quality Scale: