Move imports to top for websocket_api #29556
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
probot-home-assistant
bot
added
core
integration: websocket_api
small-pr
|
Hey there @home-assistant/core, mind taking a look at this pull request as its been labeled with a integration ( |
balloob
reviewed
Dec 8, 2019
| @@ -45,7 +45,6 @@ def handle_subscribe_events(hass, connection, msg): | |||
|
|
|||
| Async friendly. | |||
| """ | |||
| from .permissions import SUBSCRIBE_WHITELIST | |||
There was a problem hiding this comment.
There is a reason this is here. It's for circular imports.
There was a problem hiding this comment.
Thanks for the heads up! Moved it back in 6a1e5a6
balloob
approved these changes
Dec 8, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Breaking Change:
Description:
Related issue (if applicable): #27284
Pull request with documentation for home-assistant.io (if applicable): home-assistant/home-assistant.io#<home-assistant.io PR number goes here>
Example entry for
configuration.yaml(if applicable):Checklist:
tox. Your PR cannot be merged unless tests passIf user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
python3 -m script.hassfest.requirements_all.txtby runningpython3 -m script.gen_requirements_all..coveragerc.If the code does not interact with devices: