Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Default to gatttoolbackend with bluepybackend backup #27672

Closed
wants to merge 1 commit into from

Conversation

helenclarko
Copy link

This change corrects an issue with bluepy disconnecting from devices after some time.
Gatttool is currently unaffected by this issue.

No new code added, just rearranged.

Description:

Related issue (if applicable): fixes #24313

Checklist:

  • [Yes ] The code change is tested and works locally.
  • [Yes ] Local tests pass with tox. Your PR cannot be merged unless tests pass
  • [ Yes] There is no commented out code in this PR.
  • [ Yes] I have followed the development checklist

If the code does not interact with devices:

  • [ Yes] Tests have been added to verify that the new code works.

This switch corrects an issue with bluepy disconnecting from devices after some time. 
Gatttool is currently unaffected by this issue.
@homeassistant
Copy link
Contributor

Hi @helenclarko,

It seems you haven't yet signed a CLA. Please do so here.

Once you do that we will be able to review and accept this pull request.

Thanks!

@helenclarko
Copy link
Author

I'm new to creating a pull request for Home assistant, please excuse any mistakes that are made.

@balloob
Copy link
Member

balloob commented Oct 15, 2019

You're doing great :)

Fate of this PR be determined by the other PR #27673 (comment)

@pvizeli pvizeli closed this Oct 16, 2019
@lock lock bot locked and limited conversation to collaborators Oct 17, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Xiaomi BLE Temperature and Humidity sensor
4 participants