Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move imports in rflink component #27367

Merged
merged 9 commits into from
Oct 13, 2019
Merged

Move imports in rflink component #27367

merged 9 commits into from
Oct 13, 2019

Conversation

javicalle
Copy link
Contributor

@javicalle javicalle commented Oct 9, 2019 •
edited by MartinHjelmare
Loading

Breaking Change:

None

Description:

Moved import from function to top-level as requested in #27284
Related issue (if applicable):
#27284

Checklist:

  • The code change is tested and works locally.
  • Local tests pass with tox. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the [development checklist][dev-checklist]

@javicalle
Copy link
Contributor Author

At last!
Detected the real problem and fixed (someone has said 'monkeypatch').

Also regenerated the development environment. Goodbye Vagrant, hello Docker.

MartinHjelmare
MartinHjelmare approved these changes Oct 13, 2019
View reviewed changes
Copy link
Member

@MartinHjelmare MartinHjelmare left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@javicalle javicalle mentioned this pull request Oct 13, 2019
Merged
4 tasks
frenck
frenck approved these changes Oct 13, 2019
View reviewed changes
Copy link
Member

@frenck frenck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yep, that looks perfect @javicalle! 👍

Happy Hacktoberfest 🎉

@frenck frenck merged commit dd8fc41 into home-assistant:dev Oct 13, 2019
@javicalle
Copy link
Contributor Author

Thanks.

@lock lock bot locked and limited conversation to collaborators Oct 14, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@MartinHjelmare MartinHjelmare MartinHjelmare approved these changes

@frenck frenck frenck approved these changes

Assignees
No one assigned
Labels
cla-signed Hacktoberfest integration: rflink small-pr PRs with less than 30 lines.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@javicalle @frenck @MartinHjelmare @homeassistant