Move imports in hue component #27357
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
probot-home-assistant
bot
added
Hacktoberfest
integration: hue
small-pr
|
If tests are needed, I don't have Hue sensors. Also, should this line https://github.com/home-assistant/home-assistant/pull/27357/files#diff-2ff6bc353f63f5a68d63f85fd46d6c08R125 (hue/sensor_base.py:125) stay line this ? |
Kane610
reviewed
Oct 9, 2019
Quentame
force-pushed
the
hue/move_imports
branch
from
ec9b7c2 to
82140dc
Compare
|
Hue needs refactoring to avoid the circular dependencies. The sensor manager class should be moved to it's own file |
Quentame
force-pushed
the
hue/move_imports
branch
from
82140dc to
9f8f846
Compare
|
I don't get the error @balloob , am I doing right ? |
|
You're still having a circular dependency now. binary_sensor imports SensorManager, sensor manager imports binary sensor… |
Quentame
force-pushed
the
hue/move_imports
branch
from
9f8f846 to
016e0bc
Compare
|
Try multiple things tonight, but don't know how to fix for now. |
|
Then I suggest we close it for now. Leave it to someone else. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Breaking Change:
None
Description:
Moved import from function to top-level as requested in #27284
Related issue (if applicable): #27284
Checklist:
tox. Your PR cannot be merged unless tests pass