Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move imports in onkyo component #27353

Merged
merged 1 commit into from
Oct 10, 2019
Merged

Move imports in onkyo component #27353

merged 1 commit into from
Oct 10, 2019

Conversation

exxamalte
Copy link
Contributor

@exxamalte exxamalte commented Oct 9, 2019 •
edited
Loading

Breaking Change:

Description:

Moved import from function to top-level as requested in #27284

I tested this component manually with an Onkyo TX-L50 because there are unfortunately no unit tests.

Related issue (if applicable): #27284

Pull request with documentation for home-assistant.io (if applicable): n/a

Example entry for configuration.yaml (if applicable): n/a

Checklist:

  • The code change is tested and works locally.
  • There is no commented out code in this PR.
  • I have followed the development checklist

If the code communicates with devices, web services, or third-party tools:

  • Untested files have been added to .coveragerc.

@balloob balloob merged commit 0cc2d0d into home-assistant:dev Oct 10, 2019
@lock lock bot locked and limited conversation to collaborators Oct 11, 2019
@exxamalte exxamalte deleted the imports-onkyo branch October 13, 2019 04:29
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@balloob balloob balloob approved these changes

Assignees
No one assigned
Labels
cla-signed Hacktoberfest integration: onkyo small-pr PRs with less than 30 lines.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@exxamalte @balloob @homeassistant