Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move imports in caldav component #27349

Merged
merged 1 commit into from
Oct 9, 2019
Merged

Move imports in caldav component #27349

merged 1 commit into from
Oct 9, 2019

Conversation

exxamalte
Copy link
Contributor

@exxamalte exxamalte commented Oct 9, 2019 •
edited
Loading

Breaking Change:

Description:

Moved import from function to top-level as requested in #27284

Related issue (if applicable): #27284

Pull request with documentation for home-assistant.io (if applicable): n/a

Example entry for configuration.yaml (if applicable): n/a

Checklist:

  • The code change is tested and works locally.
  • Local tests pass with tox. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly. Update and include derived files by running python3 -m script.hassfest.

MartinHjelmare
MartinHjelmare reviewed Oct 9, 2019
View reviewed changes
Copy link
Member

@MartinHjelmare MartinHjelmare left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does test patching need to be updated?

@exxamalte
Copy link
Contributor Author

exxamalte commented Oct 9, 2019 •
edited
Loading

Tests ran through fine locally without any modification (py37 tested only).
I'll keep an eye on the CI result.

frenck
frenck approved these changes Oct 9, 2019
View reviewed changes
Copy link
Member

@frenck frenck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @exxamalte! 👍

Happy Hacktoberfest 🎉

@MartinHjelmare MartinHjelmare merged commit 9ea58b9 into home-assistant:dev Oct 9, 2019
@exxamalte exxamalte deleted the imports-caldav branch October 9, 2019 21:42
@lock lock bot locked and limited conversation to collaborators Oct 10, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@MartinHjelmare MartinHjelmare MartinHjelmare approved these changes

@frenck frenck frenck approved these changes

Assignees
No one assigned
Labels
cla-signed Hacktoberfest integration: caldav small-pr PRs with less than 30 lines.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@exxamalte @frenck @MartinHjelmare @homeassistant