Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update praw to 6.4.0 #27324

Merged
merged 4 commits into from
Oct 27, 2019
Merged

Update praw to 6.4.0 #27324

merged 4 commits into from
Oct 27, 2019

Conversation

fabaff
Copy link
Member

@fabaff fabaff commented Oct 8, 2019

Description:

Changelog: https://github.com/praw-dev/praw/blob/master/CHANGES.rst#640-20190921

Example entry for configuration.yaml (if applicable):

sensor:
  - platform: reddit
    username: !secret reddit_username
    password: !secret reddit_password
    client_id: !secret reddit_client_id
    client_secret: !secret reddit_client_secret
    subreddits:
      - news
      - homeassistant

Checklist:

  • The code change is tested and works locally.
  • Local tests pass with tox. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.

If the code communicates with devices, web services, or third-party tools:

  • [The manifest file][manifest-docs] has all fields filled out correctly ([example][ex-manifest]).
  • New dependencies have been added to requirements in the manifest ([example][ex-requir]).
  • New or updated dependencies have been added to requirements_all.txt by running script/gen_requirements_all.py.

@fabaff
Copy link
Member Author

fabaff commented Oct 8, 2019

Also, #27284

@balloob
Copy link
Member

balloob commented Oct 8, 2019

Because of moving it to the top of the file, it will also be needed to add to test deps in script/gen_requirements_all.py. I wonder if we should start generating that file automatically by reading the manifests of integrations that have tests.

@fabaff
Copy link
Member Author

fabaff commented Oct 10, 2019

I wonder if we should start generating that file automatically by reading the manifests of integrations that have tests.

Sounds like a plan.

@fabaff fabaff changed the title Update praw to 6.4.0 WIP: Update praw to 6.4.0 Oct 10, 2019
@balloob
Copy link
Member

balloob commented Oct 10, 2019

I've implemented and merged that in #27362

@fabaff fabaff force-pushed the upgrade-praw branch 2 times, most recently from 6de2fc5 to 4e6dcf6 Compare October 21, 2019 18:06
@fabaff fabaff mentioned this pull request Oct 22, 2019
4 tasks
@djpremier
Copy link
Contributor

djpremier commented Oct 23, 2019

Hey @fabaff, for correction tox tests (tests/components/reddit/test_sensor.py), insert: from homeassistant.components.reddit import sensor as reddit_sensor in the top-level, and with patch.object(reddit_sensor, 'praw', mock_praw): inside function test_setup_with_valid_config(), like this:

@MockDependency("praw")
@patch("praw.Reddit", new=MockPraw)
def test_setup_with_valid_config(self, mock_praw):
    """Test the platform setup with movie configuration."""
    with patch.object(reddit_sensor, 'praw', mock_praw):
        setup_component(self.hass, "sensor", VALID_CONFIG)

@fabaff fabaff changed the title WIP: Update praw to 6.4.0 Update praw to 6.4.0 Oct 26, 2019
@fabaff
Copy link
Member Author

fabaff commented Oct 26, 2019

@djpremier, thanks.

@fabaff fabaff merged commit 7e862e4 into dev Oct 27, 2019
@delete-merged-branch delete-merged-branch bot deleted the upgrade-praw branch October 27, 2019 09:04
@lock lock bot locked and limited conversation to collaborators Oct 28, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants