Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unused Sonos turn on/off methods #24174

Merged
merged 1 commit into from
May 29, 2019

Conversation

amelchio
Copy link
Contributor

Description:

These methods have been unaccessible since #22878.

An alternative would be to re-enable the methods by adding appropriate feature flags. However, Sonos is an always-on device so it seems right to leave out turn on/off.

Checklist:

  • The code change is tested and works locally.
  • Local tests pass with tox.
  • There is no commented out code in this PR.
  • I have followed the [development checklist][dev-checklist]

@ghost ghost assigned amelchio May 29, 2019
@balloob balloob merged commit bebfc3d into home-assistant:dev May 29, 2019
@balloob balloob mentioned this pull request Jun 4, 2019
alandtse pushed a commit to alandtse/home-assistant that referenced this pull request Oct 12, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants