Correct hue light level units and value calculation

[mitchellrj]

As pointed out by #22598 (comment)

[ghost]

Hey there @balloob, mind taking a look at this pull request as its been labeled with a integration (hue) you are listed as a codeowner for? Thanks!

This is a automatic comment generated by codeowners-mention to help ensure issues and pull requests are seen by the right people.

[SeanPM5]

It seems that after updating from b2 to b3 the sensor values are extremely different, so I think there might be a minor bug with the calculation/rounding here.

It used to report easy to read values like 3847 and now it's very long numbers that do not appear rounded 46.838178785024404 lx.

Here is a quick screen recording demonstrating the difference when scrolling through values on the more-info window: https://gfycat.com/ThreadbareUnfinishedGnatcatcher

[mitchellrj]

Hmm. With such a high level of variance, there can be a very large difference at low light levels between say 0.001 and 0.1. The UI should be responsible for rounding IMO with the "real" ungrounded values available for other uses still. What we've run into really, is the very reason Philips choose not to represent this value in lumens or lux.

…

On Tue, 23 Apr 2019, 20:14 SeanPM5, ***@***.***> wrote: It seems that after updating from b2 to b3 the sensor values are extremely different, so I think there might be a minor bug here. It used to report easy to read values like 3847 and now it's very long numbers that do not appear rounded 46.838178785024404 lx — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <#23309 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AABD47RC2M5QFF7USNVJP33PR5NZ3ANCNFSM4HHSF3AQ> .

[Mariusthvdb]

not sure if this is still allowed here, but the new light_level sensors are displaying lx, and not the native light_level off of the Hue hub. Might be better calling them likewise, sensor.X_sensor_lx.

Feel with @SeanPM5 on the rounding, which could be a bit less precise (put differently, please round to max 2 decimals). There's really no use case for more precision, even at low lightlevels, and it either forces users to have horrible UI, or create extra template sensors to mitigate that... compare this:

to:

community-post: https://community.home-assistant.io/t/new-hue-light-level-sensors-are-in-fact-lux-sensors/115112

this is Philips own light_level table and shows no use for these light_level detailing:

#Philips Hue definition                 Lux               MeasuredValue
#Overcast moonless night sky              0.0001                  0
#Outdoor: Bright moonlight                1                       1
#Home: Night light                        2                    3000
#Home: Dimmed light                      10                   10000
#Home: ‘Cosy’ living room                50                   17000
#Home: ‘Normal’ non-task light          150                   22000
#Home: Working / reading                350                   25500
#Home: Inside daylight                  700                   28500
#Home: Maximum to avoid glare          2000                   33000
#Outdoor: Clear daylight            > 10000                 > 40000
#Outdoor: direct sunlight            120000                   51000

[MartinHjelmare]

Please open an issue if you suspect a bug.

If you want to suggest an enhancement please open a feature request in the Feature Requests section of our community forum.

Merged PRs should not be used for enhancement discussion or bug reports. If you've found a bug it's ok to make a review with inline comments and link to an issue that reports the bug.

Thanks!