Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix errant import #23081

Merged
merged 1 commit into from
Apr 13, 2019
Merged

Fix errant import #23081

merged 1 commit into from
Apr 13, 2019

Conversation

bachya
Copy link
Contributor

@bachya bachya commented Apr 13, 2019

Description:

An errant import leaked in.

Related issue (if applicable): fixes #

Pull request in home-assistant.io with documentation (if applicable): home-assistant/home-assistant.io#<home-assistant.io PR number goes here>

Example entry for configuration.yaml (if applicable):

Checklist:

  • The code change is tested and works locally.
  • Local tests pass with tox. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly (example).
  • New dependencies have been added to requirements in the manifest (example).
  • New dependencies are only imported inside functions that use them (example).
  • New or updated dependencies have been added to requirements_all.txt by running script/gen_requirements_all.py.
  • New files were added to .coveragerc.

If the code does not interact with devices:

  • Tests have been added to verify that the new code works.

@bachya bachya requested a review from a team as a code owner April 13, 2019 21:20
@bachya bachya self-assigned this Apr 13, 2019
@homeassistant homeassistant added cla-signed core small-pr PRs with less than 30 lines. labels Apr 13, 2019
@ghost ghost added the in progress label Apr 13, 2019
@bachya bachya changed the title Fix test Fix errant import Apr 13, 2019
@balloob balloob merged commit 46ee7d7 into home-assistant:dev Apr 13, 2019
@ghost ghost removed the in progress label Apr 13, 2019
@bachya bachya deleted the leak branch April 13, 2019 21:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla-signed core small-pr PRs with less than 30 lines.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants