Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Convert translation helper to use async_get_integration #23054

Merged
merged 5 commits into from
Apr 13, 2019
Merged

Conversation

balloob
Copy link
Member

@balloob balloob commented Apr 12, 2019

Description:

Use async_get_integration inside the translation helper.

Related issue (if applicable): fixes #23007

Checklist:

  • The code change is tested and works locally.
  • Local tests pass with tox. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.

If the code does not interact with devices:

  • Tests have been added to verify that the new code works.

@balloob balloob requested a review from a team as a code owner April 12, 2019 18:43
@homeassistant homeassistant added core small-pr PRs with less than 30 lines. cla-signed labels Apr 12, 2019
@ghost ghost assigned balloob Apr 12, 2019
@ghost ghost added the in progress label Apr 12, 2019
homeassistant/helpers/translation.py Outdated Show resolved Hide resolved
homeassistant/helpers/translation.py Outdated Show resolved Hide resolved
@codecov
Copy link

codecov bot commented Apr 12, 2019

Codecov Report

Merging #23054 into dev will decrease coverage by <.01%.
The diff coverage is 94.73%.

Impacted file tree graph

@@            Coverage Diff             @@
##              dev   #23054      +/-   ##
==========================================
- Coverage   93.94%   93.94%   -0.01%     
==========================================
  Files         451      450       -1     
  Lines       36758    36752       -6     
==========================================
- Hits        34531    34525       -6     
  Misses       2227     2227
Impacted Files Coverage Δ
homeassistant/helpers/translation.py 98.7% <94.73%> (-0.04%) ⬇️
homeassistant/components/broadlink/const.py

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0a3e11a...b99d2fe. Read the comment docs.

@balloob balloob merged commit 3f69d02 into dev Apr 13, 2019
@ghost ghost removed the in progress label Apr 13, 2019
@delete-merged-branch delete-merged-branch bot deleted the translation-helper branch April 13, 2019 00:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla-signed core small-pr PRs with less than 30 lines.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Convert translation helper to use get_integration
3 participants