Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove aws_* notify platforms #22698

Merged
merged 1 commit into from
Apr 4, 2019

Conversation

awarecan
Copy link
Contributor

@awarecan awarecan commented Apr 4, 2019

Breaking Change:

aws_lambda, aws_sns, and aws_sqs notify platforms have been consolidate to aws component in 0.91 release with warning message. In 0.92 release, we will remove those files.

Description:

See #22240 for more information

Related issue (if applicable): fixes #

Pull request in home-assistant.io with documentation (if applicable): home-assistant/home-assistant.io#TBD

Example entry for configuration.yaml (if applicable):

aws:
  # credentials is optional, if omitted, a default credential will be created
  # which use default profile defined in ~/.aws
  credentials:
    - name: Default Profile
      # can use profile defined in ~/.aws
      profile_name: default
    - name: Test Profile
      # or use aws access key directly
      aws_access_key_id: some-id
      aws_secret_access_key: some-key
  notify:
    # can use the first credential defined in component by default
    - service: lambda
      name: Lambda Notify
      region_name: us-east-1
    # can config the credential defined in component
    - service: sns
      name: SNS Notify use Default Profile
      credential_name: Default Profile
      region_name: us-east-1
    # can config the profile or access key
    - service: sqs
      name: SQS Notify
      profile_name: test
      region_name: us-east-1

Checklist:

  • The code change is tested and works locally.
  • Local tests pass with tox. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • New or updated dependencies have been added to requirements_all.txt by running script/gen_requirements_all.py.
  • New files were added to .coveragerc.

@codecov
Copy link

codecov bot commented Apr 4, 2019

Codecov Report

Merging #22698 into dev will decrease coverage by <.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##              dev   #22698      +/-   ##
==========================================
- Coverage   93.84%   93.83%   -0.01%     
==========================================
  Files         449      449              
  Lines       36568    36568              
==========================================
- Hits        34317    34314       -3     
- Misses       2251     2254       +3
Impacted Files Coverage Δ
...ssistant/components/islamic_prayer_times/sensor.py 94.73% <0%> (-3.16%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a85bcce...b5fceef. Read the comment docs.

1 similar comment
@codecov
Copy link

codecov bot commented Apr 4, 2019

Codecov Report

Merging #22698 into dev will decrease coverage by <.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##              dev   #22698      +/-   ##
==========================================
- Coverage   93.84%   93.83%   -0.01%     
==========================================
  Files         449      449              
  Lines       36568    36568              
==========================================
- Hits        34317    34314       -3     
- Misses       2251     2254       +3
Impacted Files Coverage Δ
...ssistant/components/islamic_prayer_times/sensor.py 94.73% <0%> (-3.16%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a85bcce...b5fceef. Read the comment docs.

homeassistant/components/notify/aws_lambda.py @robbiet480
homeassistant/components/notify/aws_sns.py @robbiet480
homeassistant/components/notify/aws_sqs.py @robbiet480
homeassistant/components/notify/file.py @fabaff
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please double check that you properly re-distributed these, I think at least tts.amazon_polly is missing.

CODEOWNERS Show resolved Hide resolved
@awarecan awarecan mentioned this pull request Apr 4, 2019
@balloob balloob merged commit 6aac49d into home-assistant:dev Apr 4, 2019
@ghost ghost removed the in progress label Apr 4, 2019
unibeck pushed a commit to unibeck/home-assistant that referenced this pull request Apr 7, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants