-
-
Notifications
You must be signed in to change notification settings - Fork 31.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove aws_* notify platforms #22698
Remove aws_* notify platforms #22698
Conversation
Codecov Report
@@ Coverage Diff @@
## dev #22698 +/- ##
==========================================
- Coverage 93.84% 93.83% -0.01%
==========================================
Files 449 449
Lines 36568 36568
==========================================
- Hits 34317 34314 -3
- Misses 2251 2254 +3
Continue to review full report at Codecov.
|
1 similar comment
Codecov Report
@@ Coverage Diff @@
## dev #22698 +/- ##
==========================================
- Coverage 93.84% 93.83% -0.01%
==========================================
Files 449 449
Lines 36568 36568
==========================================
- Hits 34317 34314 -3
- Misses 2251 2254 +3
Continue to review full report at Codecov.
|
homeassistant/components/notify/aws_lambda.py @robbiet480 | ||
homeassistant/components/notify/aws_sns.py @robbiet480 | ||
homeassistant/components/notify/aws_sqs.py @robbiet480 | ||
homeassistant/components/notify/file.py @fabaff |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please double check that you properly re-distributed these, I think at least tts.amazon_polly
is missing.
Breaking Change:
aws_lambda
,aws_sns
, andaws_sqs
notify platforms have been consolidate toaws
component in 0.91 release with warning message. In 0.92 release, we will remove those files.Description:
See #22240 for more information
Related issue (if applicable): fixes #
Pull request in home-assistant.io with documentation (if applicable): home-assistant/home-assistant.io#TBD
Example entry for
configuration.yaml
(if applicable):Checklist:
tox
. Your PR cannot be merged unless tests passIf user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
requirements_all.txt
by runningscript/gen_requirements_all.py
..coveragerc
.